search

bigdataviewer / bigdataviewer-playground

BSD 2-Clause "Simplified" License
19 stars 5 forks source link

ScreenShotMaker #232

Closed tischi closed 1 month ago

tischi commented 3 years ago

@NicoKiaru

Sorry, I am sure I asked this before, but where did the ScreenShotMakerCommand go?

I think I remember that the issue was the the ScreenShotMaker needs to know about the AccumulateProjector and it was not clear how to handle this?

tischi commented 3 years ago

I guess for now I could just have the ScreenShotMaker that works with the AccumulateMixedProjector inside the MoBIE repo? And then also move the AccumulateMixedProjector into the MoBIE repo?

Long term we could maybe think about whether the BdvSupplier could also supply the corresponding Projector?

NicoKiaru commented 3 years ago

Long term we could maybe think about whether the BdvSupplier could also supply the corresponding Projector?

Totally agree, we should do that and restore the ScreenShotMaker in bdv-playground, using this projector info

NicoKiaru commented 2 years ago

Hi Tischi, I've added a method to access the accumulator. There's a default method that needs to be overriden ( probably in https://github.com/mobie/mobie-viewer-fiji/blob/main/src/main/java/org/embl/mobie/viewer/bdv/MobieBdvSupplier.java). I hope that'll solve this issue.

NicoKiaru commented 1 month ago

@tischi can this be closed ? It's an old issue, not sure what should be done anymore.