search

bigdataviewer / bigdataviewer-vistools

Helpers to use BigDataViewer as a quick visualization tool in other projects.
BSD 2-Clause "Simplified" License
25 stars 17 forks source link

Make version of BdvFunctions.show( Source ) with numTimePoints argument #26

Closed tischi closed 5 years ago

tischi commented 5 years ago

Added a version of BdvFunctions.show for a source with numTimepoints argument. Also added an ExampleSource4D in src/test/... demonstrating the functionality. It would be nice if this could be merged (or differently resolved) as I need the functionality for a project.

Conceptually, I do not really understand why a source does not itself know how many time-points it has? One can currently say source.isPresent( t ), but not source.getNumTimepoints(). I would be curious to why that is designed like this. If there was a source.getNumTimepoints() function, one would not need to manually specify the number of time-points in BdvFunctions.show().

tpietzsch commented 5 years ago

Conceptually, I do not really understand why a source does not itself know how many time-points it has? One can currently say source.isPresent( t ), but not source.getNumTimepoints(). I would be curious to why that is designed like this. If there was a source.getNumTimepoints() function, one would not need to manually specify the number of time-points in BdvFunctions.show().

Not much design involved, as usual just "historical reasons"... Number of timepoints was a property of the (lightsheet) dataset, so higher-level than Source. I.e., all the sources would have the same number of timepoints anyway.

tpietzsch commented 5 years ago

thanks!