bigdataviewer / bigdataviewer-vistools

Helpers to use BigDataViewer as a quick visualization tool in other projects.
BSD 2-Clause "Simplified" License
25 stars 17 forks source link

bdv.utils.VolatileSource conflicts with playground #62

Closed mkitti closed 9 months ago

mkitti commented 9 months ago

There is another bdv.utils.VolatileSource in bigdataviewer-playground:

https://github.com/bigdataviewer/bigdataviewer-playground/blob/05c48eef7fa724e32bc595ea8949c206cdbe2333/src%2Fmain%2Fjava%2Fbdv%2Futil%2FVolatileSource.java#L88

tpietzsch commented 9 months ago

Argh. We should really adopt naming packages after artefacts. bdv.util should be org.bigdataviewer.vistools for bigdataviewer-vistools. And org.bigdataviewer.playground for bigdataviewer-playground.

tpietzsch commented 9 months ago

@axtimwalde @NicoKiaru Can you estimate how widely used your respective versions of VolatileSource are? Can we still just rename one of them?

NicoKiaru commented 9 months ago

I've renamed the one in bigdataviewer-playground, it's used only internally and is not in any of the persisted json files around.

If I find some time, I'll do it this week, but most probably next week.

I want to fix the compability with BigWarp at the same time.

NicoKiaru commented 9 months ago

But I need to have a parent pom scijava with a stable version to make my builds!

It's not the case now: https://github.com/scijava/pom-scijava/pull/254

I just test with a temp snapshot parent pom from @bogovicj 's branch, but I can't release because of that

imagesc-bot commented 9 months ago

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/updated-ngff-support-in-fiji-hdf5-n5-zarr-ome-ngff/91705/43

imagesc-bot commented 9 months ago

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/updated-ngff-support-in-fiji-hdf5-n5-zarr-ome-ngff/91705/44

axtimwalde commented 9 months ago

playground will rename its source or re-use the vistools implementation after bugs are fixed