search

bigdong89 / xgboostExtension

xgboost Extension for Easy Ranking & TreeFeature
Apache License 2.0
123 stars 35 forks source link

forward compatibility with xgboost 0.90 #19

Open luoshao23 opened 5 years ago

luoshao23 commented 5 years ago

change positional arguments to keyword arguments for the forward compatibility with xgboost 0.90

luoshao23 commented 5 years ago

When I used the xgboostExtension on xgboost 0.90, I found the XgbRanker class was not properly initialized with correct value in each argument. So I updated the arguments to keyword style for better compatibility.

FlorisHoogenboom commented 5 years ago

When using XGBoost 0.90 or up I would propose using the XGBRanker object that has been made available as part of the scikit-learn api there instead of relying on this module. So maybe it would be better to make users aware that this is not meant to be used with that version?

bigdong89 commented 5 years ago

@FlorisHoogenboom I'm going to have a try and make the decision.