search

bigfish / vim-js-context-coloring

JavaScript Context Coloring in Vim
MIT License
151 stars 8 forks source link

added support for gvim #7

Closed 97-109-107 closed 10 years ago

97-109-107 commented 10 years ago

I have an idea to enable the user to setup his own colors as xterm reference or RGB and then apply the highlight dependent on the users settings - but this scheme breaks down if he/she launches g/vim in the mode they didn't prepare the plugin for. Didn't want to dabble further than this, maybe you have a suggestion?

bigfish commented 10 years ago

Thanks, that would indeed work well for the default colors. But if the colors were customized by the user, they would not get the benefit of using both terminal and gui vim with the same color scheme (not sure if this is likely but seems like a good goal). I came up with the idea of translating the given colors into the appropriate color name for the environment, by using a table from another plugin, plus a list of color names gleaned from the Vim docs. As a result, the plugin should now transparently work in GUI vim and terminal, and support color names, which are more human readable. It also now allows a more advanced color definition with a Dictionary with the same keys as the options to the 'highlight' command. So it is now also possible to specify background colors, which I personally am not a fan of, but perhaps it could be done more subtly.

So check out the latest version, and see if it works for you. Its always quite motivating to get pull requests!

bigfish commented 10 years ago

closing this request.. see new version 0.0.6 for gVim support (now also at vim.org).