search

bigfive / atom-sublime-select

Enable 'sublime style' multiline selection boxes to Atom editor http://atom.io
MIT License
233 stars 49 forks source link

Scrolling during block selection "freezes" block selection #10

Closed iccir closed 10 years ago

iccir commented 10 years ago

While testing the fix to #7, I noticed that, if I attempt to scroll the buffer while block selecting (via dragging the cursor to the bottom of the editor or top of the editor), the scroll is prevented from occurring, and the block selection freezes.

In Sublime, the scroll happens and the block selection continues.

bigfive commented 10 years ago

Yeah, I added that in intentionally until I fix a different bug. If i remove that 'freezing' (i trigger a mouseup on mouseleave) then 2 sets of selection boxes are drawn when you bring the cursor back into the view.

I'll have another look at it later. I just added the freezing in so I could release this new version

iccir commented 10 years ago

No problem, I just wanted to mention it and get it down in the issue tracker ;) Thanks so much for the plugin and for the work tonight!

bigfive commented 10 years ago

Yup. Cheers for the testing feedback mate

bigfive commented 10 years ago

@iccir Ive just released an update that should fix this It just does a preventDefault on mouseLeave when the altkey is down. The caveat for this is that if you mouseUp while outside the editor the mouseUp event wont fire so you will still have an active selection box (with no mouse button down). To get around this just middle-click when you have the correct selection.

bigfive commented 10 years ago

Note the caveat I mention is related to: https://github.com/bigfive/atom-sublime-select/issues/16

bigfive commented 10 years ago

Ive further fixed this issue in the latest release. The caveat mentioned above should no longer apply