bigfive / atom-sublime-select

Enable 'sublime style' multiline selection boxes to Atom editor http://atom.io
MIT License
233 stars 49 forks source link

Select not working #3

Closed ghelton closed 10 years ago

ghelton commented 10 years ago

Not sure what info to give here, but its not working for me. I'm using Atom on Mavericks 10.9.2, when I try to hold down alt and drag the cursor, selection works the same as before I installed. I also tried restarting Atom. Let me know if there is a way for me to debug, thanks!

amencarini commented 10 years ago

Not working for me either. Same setup as @astrism

jtokoph commented 10 years ago

It has to do with a bug added to atom in an update. I think it should be fixed on the next atom release: https://github.com/atom/atom-keymap/commit/3c2eca253f826ea9b862a67608825c21ec7dcf57

In the meantime, add this code to /Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/helpers.js at line 65:

EDIT: line 74 as of Atom 0.80

    if (key === "meta" || key === "shift" || key === "control" || key === "alt") {
      key = null;
    }
pavelnikolov commented 10 years ago

@jtokoph it doesn't work for me with version 0.84

I put this on line 74 as suggested and nothing changes. Can you please provide some context 5 previous and 5 following rows?

bigfive commented 10 years ago

@pavelnikolov Ive just release a new version including some fixes from @jtokoph. Can you update your package and give it a go now.

pavelnikolov commented 10 years ago

I just updated to version 0.85 and I still do not have vertical selection. Am I missing something?

pavelnikolov commented 10 years ago

@bigfive I do have vertical selection with only using keyboard - ctrl + + up/down. But it doesn't work as in any other code editor (TextMate, Sublime, VS etc.) - alt + click + drag. Any help on how to resolve this would be much appreciated!

ajoslin103 commented 10 years ago

it only works for me if I am NOT selecting a column from the left edge, I cannot get a column down the left edge at all -- I only end up with normal highlighted text selection

without very careful mouse movements I can get multiple carets in a column (as desired) PLUS a line or two of normal highlighted text selection

this is so close !!

OSX 10.9.2 - Atom 0.90.0 - atom-sublime-select 0.4.5

alexlafroscia commented 10 years ago

Not working if I drag directly downward. However, if I drag downward and to the right, it works. It would be nice if it replicated how Sublime operates, where you can drag directly down to just insert the cursor and not have to select text at the same time.

bigfive commented 10 years ago

I'm going to close this issue. ajoslin103 and alexlafroscia it sounds like your having a different issue / want a different feature than the op, can you make a new issue please. I'll have a look at ensuring vertical selection from the far left is working.