search

bigflood / dartexif

Dart package to decode Exif data from tiff, jpeg and heic files
https://pub.dev/packages/exif
MIT License
30 stars 29 forks source link

Commit for migrate to null-safety #20

Closed bhavin-concetto closed 3 years ago

bhavin-concetto commented 3 years ago
bigflood commented 3 years ago

@bhavin-concetto You should exclude .idea directory.

bhavin-concetto commented 3 years ago

@bigflood I have updated the code but the one test is still not passing.

bigflood commented 3 years ago

@bhavin-concetto

I updated samples-exif.json file. You need to merge this commit -> https://github.com/bigflood/dartexif/commit/98f6988cd9a237d44622733b21d2642eb99fc99a

bigflood commented 3 years ago

@bhavin-concetto I would appreciate it if you could fix unnecessary_null_comparison warnings.

# dartanalyzer lib
Analyzing lib...
  hint • The operand can't be null, so the condition is always false. • lib/src/linereader.dart:42:13 • unnecessary_null_comparison
  hint • The operand can't be null, so the condition is always false. • lib/src/makernote_olympus.dart:32:11 • unnecessary_null_comparison
  hint • The operand can't be null, so the condition is always false. • lib/src/makernote_olympus.dart:36:11 • unnecessary_null_comparison
3 hints found.
bhavin-concetto commented 3 years ago

@bigflood please check now.

bigflood commented 3 years ago

@bhavin-concetto Good!