biggora / caminte

Cross-db ORM for NodeJS
http://www.camintejs.com/
MIT License
1.08k stars 119 forks source link

Arango Query filter never executed #183

Open izhur opened 6 years ago

izhur commented 6 years ago

I see in lib/adapters/arango.js line 263

Object.keys(filter.where).length === 0 on if condition made, no filter on query will be executed.

should it be

Object.keys(filter.where).length !== 0 ??

This is lib/adapters/arango.js line 262 to 269

if (filter) {
        if (filter.where && Object.keys(filter.where).length === 0) {
            var csql = self.buildWhere(filter.where, self, model);
            query.push(csql.query.join(' '));
            Object.keys(csql.bindVars).forEach(function (bkey) {
                bindVars[bkey] = csql.bindVars[bkey];
            });
        }
izhur commented 6 years ago

fork commit https://github.com/derevandal/caminte/commit/baaf0a100c72ecba7ad6916622f1c87c794c7ce0 fixed this, and having better handling for auto create collections