biggora / caminte

Cross-db ORM for NodeJS
http://www.camintejs.com/
MIT License
1.09k stars 119 forks source link

Depricated code in Redis driver #90

Open xtremespb opened 8 years ago

xtremespb commented 8 years ago

The code in Redis driver is deprecated. If there's no auth information for Redis server provided in config, the following warnings are shown in console:

node_redis: Deprecated: The AUTH command contains a "undefined" argument. This is converted to a "undefined" string now and will return an error from v.3.0 on. Please handle this in your code to make sure everything works as you intended it to. node_redis: Warning: Redis server does not require a password, but a password was supplied.

The fix is pretty simple, to change the following line (38) in adapters/redis.js:

schema.client.auth(schema.settings.password);

to

if (schema.settings.password) schema.client.auth(schema.settings.password);

I can try to make a pool request here when necessary.

ellisio commented 8 years ago

This is a pain, and highly needed. We don't have a password due to a bug within socket.io-redis and have decided to lock down our Redis via other security methods.

tyronedougherty commented 8 years ago

I've fixed this issue in Pull Request #93

Hopefully it is merged across soon :)

tyronedougherty commented 8 years ago

Fixed in #93, merged

odilitime commented 7 years ago

close ticket?