search

biglocalnews / civic-scraper

Tools for downloading agendas, minutes and other documents produced by local government
https://civic-scraper.readthedocs.io
Other
42 stars 13 forks source link

Python 3.6 builds failing due to crytography install snafu #98

Closed hancush closed 2 years ago

hancush commented 2 years ago

Hey, @zstumgoren! We're starting work in our fork and noticed Python 3.6 builds are failing. Here's the build log: https://app.travis-ci.com/github/datamade/civic-scraper/jobs/543463196

Upgrading pip didn't seem to resolve the issue. Seems best to make this fix in this upstream repo, anyhow. Any ideas?

Happy to work together on a PR, if need be!

zstumgoren commented 2 years ago

In the past I've had luck installing cryptography separately from the standard requirements file. This post contains some advice that might be worth trying, starting with a generic pip install cryptography. We'd need to add that update to tox.ini to see if it works. Would be greatly appreciated if you can test and, if it works, send us a PR. Thanks!

zstumgoren commented 2 years ago

@hancush You may need to experiment with adding that explicit install to different parts of tox.ini, e.g. in the basepython section. I'd also be curious to see if the same error arises during a standard end-user install on Python 3.6 (e.g. on a Mac dev machine as opposed to a Linux-based container on Travis).

Anyhow, hopefully that helps get started with some experiments. If this becomes a time sink, we can skip 3.6 support for now and pivot instead to Legistar implementation

fgregg commented 2 years ago

part of the issue is that that tox is not using the system pip, but a very old version of pip. pip 10, to be precise. that version of pip doesn't know about wheels.

https://app.travis-ci.com/github/datamade/civic-scraper/jobs/543463196#L222