biglocalnews / warn-scraper

Command-line interface for downloading WARN Act notices of qualified plant closings and mass layoffs from state government websites
https://warn-scraper.readthedocs.io
Apache License 2.0
29 stars 10 forks source link

Consider switching to pyright for type-checking #627

Closed chriszs closed 6 months ago

chriszs commented 6 months ago

In my experience, it is slightly better than mypy at catching typing issues (though I recall seeing some examples of issues which mypy flags but pyright does not). Here's some documentation on the differences: https://github.com/microsoft/pyright/blob/main/docs/mypy-comparison.md

The upshot is that pyright, which powers VS Code's Pylance checking (which as we speak is highlighting the code with all sorts of red squiggles), is somewhat more advanced than mypy.

stucka commented 6 months ago

I'm game for keeping this open -- probably above my paygrade to decide this is right or not but I can run it up the flagpole?