Closed biglovisa closed 8 years ago
Hey! I think this is fantastic so far. The specs themselves read very clearly and have really nice incremental progressions. I left a few comments around testing strategies and a few other random thoughts.
Here are a few more in no particular order:
SimpleAddNewForm
could potentially be simplified to SimpleForm
src/03/SimpleAddNewForm-test.js
or src/03/__tests__/SimpleAddNewForm-test.js
) helps the exercises feel like a "unit". We can have users run each test file directly, meaning they won't have to worry about re-xit
ing tests after completing exercises when using something like npm test
form
tag and adding a label for the text input
(https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/forms/Basic_form_hints)I'm happy to help with any of these :star: 😄
SimpleForm
name README
that goes through the skeleton code in each example and explain more in detail what the prop types are. What do you think? :ship:
For your consideration, @wfro :zap:
A component that submits a value. Not super interesting, but the next exercise could be a more complex one with multiple fields with validations.
solution