bigmanmad / torchesntrinkets-1.20.1

0 stars 0 forks source link

Water Sensitivity Check #5

Closed geometryflame111 closed 1 month ago

geometryflame111 commented 2 months ago

While testing the Latest Version on Fabric 1.20.1, I noticed an irregularity. LambDynamicLights treats all three trinkets as if they are sensitive to light.

The Torch Belt makes sense, it's a torch. However, lanterns can be waterlogged (and are therefore canonically waterproof). The Lantern Belt and Soul Lantern Belt should therefore not be sensitive to water.

Image

geometryflame111 commented 2 months ago

I figured I should mention, I already know that I can disable the water sensitivity configuration. However, items like the lantern are already treated as water insensitive by LambDynamicLights. I imagine it should also be possible to transfer this property to the lantern trinkets, unless there's a related issue with Radiant Gear that prevents this.

bigmanmad commented 2 months ago

its likely to do with radiant gear as my mod just adds a trinket slot and a few items, the dynamic lighting is handled with radiant gear's trinket stuff and obviously dynamic lights, perhaps im wrong and if so let me know so i can fix it

geometryflame111 commented 2 months ago

If I had to guess, I'd say you're missing some configuration files. Alternatively, there may be some kind of property you could add to the items, but I got onto the Radiant Gear Discord Server and noticed a few cases where people were asking questions about it and configuration files for dynamic light mods were mentioned. Perhaps that's the solution?

I asked a question in the Support Channel to check, but as of writing this haven't had an immediate response.

geometryflame111 commented 2 months ago

Would having an example help? I found a mod called Wearable Lanterns. Dug through the code a bit, I think I found the related files. You just need to change a boolean value...