bigmantate / wk8review

GNU General Public License v3.0
0 stars 1 forks source link

Small suggestions and errors #4

Open luschool opened 6 years ago

luschool commented 6 years ago

Want to start by saying I ran this on a virtual machine with debian.

As noted in another issue flow control would help make it clear whats going on each step of the way. I suggest piping lines 34 to | less since it outputs so much info. Line 34 - cd /dev; ls -l Same could be done for line 38 - udevadm info --query=all --name=/dev/sda

Line 44 error "./wk8.sh: mkfs: not found" I think you have to run the mkfs as sudo(atleast on my debian virtual machine you do) - mkfs -t ext4 ./64MB.img

Same with mkdir on line 46 since its trying to create inside root directory - mkdir /mnt/tmp

The above line causes line 47 to not work since the directory was never made.

Line 51 I get the error "51: cd: can't cd to /tmp/tmp" I assume because the directory doesnt exist Line 51 - cd /tmp/tmp; ls

Line 67 atleast for debian it seems you need to run dmesg as sudo dmesg | less

error with line 77 : "Failed to start echo.socket: Unit echo.socket not found." systemctl start echo.socket

I look forward to the changes you mentioned in the other issues and hope these insights were helpful!

bigmantate commented 6 years ago

Thank you. Very good feedback, I appreciate you taking the time to review my script. Good changes coming soon.