search

bigmlcom / sensenet

0 stars 8 forks source link

Integration Nits #22

Closed charleslparker closed 3 years ago

charleslparker commented 3 years ago

We weren't handling dropblock layers properly at serialization and also the /tmp and /volatile/tmp volumes are on different devices in prod, and so os.rename fails.

charleslparker commented 3 years ago

@unmonoqueteclea - yeah I agree. When you've done this to you use shutil.move, or just copy and delete separately? It seems like there's some controversy about whether or not shutil.move actually works as documented (see comments on https://stackoverflow.com/a/43967659/790979).

unmonoqueteclea commented 3 years ago

@charleslparker The last time was actually in my fork of antineutron (https://github.com/unmonoqueteclea/antineutron/commit/412206c842051ef724efdf79b90aeb4950cab3b1) shutil.move worked as expected