search

bigmlcom / sensenet

0 stars 8 forks source link

chore: ensure Github actions run tests in Python 3.10 and 3.11 #42

Closed unmonoqueteclea closed 7 months ago

unmonoqueteclea commented 8 months ago

We didn't update the Python versions where we want tests to run. They were just running in Python 3.9. I also removed the Install Test Dependencies section, because those two dependencies are already part of the package requirements list.

I am not sure if this PR will trigger the new workflow with the new versions, or we will have to merge it first and it will run in the next PR. Anyways, I found that wheels build process failed in the previous PR. We will need to check why (I still don't know), because wheels make that Python packages installations much faster and stable.

Furthermore, I am seeing a strange error locally in a test. I want to check tests logs here before starting to work on it.

cc @mmerce @jaor

unmonoqueteclea commented 8 months ago

Sorry for the noise, I finished testing Github Actions.

Tests are finally running in 3 different Python versions (3.9, 3.10 and 3.11) and the pipeline that builds the wheels for macOS is working correctly.

The pipeline that builds wheels for Linux is not working and the reason was explained some time ago here: The problem is that we are extending Tensorflow with C extensions to add a new small feature to it, tree embeddings. This is making Sensenet much more complex to build and to install.

In Charlie's words:

 This extension has been such a pain so many times that maybe we should remove it.

Maybe, we should re-consider this

unmonoqueteclea commented 8 months ago

Hey, any comments? Shall I merge this?

unmonoqueteclea commented 7 months ago

Tests are passing, and changes are just related with tests and Github Actions, I will merge this.