search

bigmoby / fglair_for_homeassistant

❄️ FGLair heat pump controller integration
MIT License
48 stars 4 forks source link

Use default timeout #119

Closed drc38 closed 4 months ago

drc38 commented 4 months ago

@bigmoby the 10s timeout causes issues with my system, suggest using default to relax timing exception

bigmoby commented 4 months ago

Hi @drc38 , what kind of issue are you having? Please if you could post the exception log and give me the rationale under which you suggest to avoid asyncio timeout, thanks

drc38 commented 4 months ago

Hi @drc38 , what kind of issue are you having? Please if you could post the exception log and give me the rationale under which you suggest to avoid asyncio timeout, thanks

There's not a lot to see in the log it just shows a data update exception. However when this happens then calls to the AC unit no longer work eg a turn on service call. Using HASS's default timeout (which I think is 30s) by removing the asyncio reference removes the exceptions and I no longer have issues calling services to turn the unit on/off etc.

bigmoby commented 4 months ago

Hi @drc38 thank you for your PR but in this case I prefer to adopt an alternative approach and maintain asyncio.timeout function. I hope that release 0.3.8 will solve your issue: default timeout 60 seconds.

drc38 commented 4 months ago

Hi @drc38 thank you for your PR but in this case I prefer to adopt an alternative approach and maintain asyncio.timeout function. I hope that release 0.3.8 will solve your issue: default timeout 60 seconds.

No problem, if I still have the issue with 0.3.8 I'll let you know.