- updates for Xcode 8 beta 4

bignerdranch / Freddy

A reusable framework for parsing JSON in Swift.

MIT License

1.09k stars 120 forks source link

Closed tomcomer closed 8 years ago

tomcomer commented 8 years ago

Renamed JSON.Error to JSON.JSONError to avoid conflict with Error type in swift 3 with Xcode 8 beta 4
Renamed JSONParser.Error to JSONParser.ParserError to avoid conflict with Error type in swift 3 with Xcode 8 beta 4

zwaldowski commented 8 years ago

I think I'd rather not change the use sites, and instead use enum Error: Swift.Error { at the declaration site. @mdmathias, thoughts?

jgallagher commented 8 years ago

I concur - changing to enum Error: Swift.Error is exactly the tactic @mdmathias and I chose to use in a different context yesterday.

mdmathias commented 8 years ago

Yep, was just going to chime in to the same effect.

tomcomer commented 8 years ago

Good points. I've updated the commits to use the better fix.

jgallagher commented 8 years ago

Thanks! I rebased this and included a few fixes for the unit tests and merged as part of #187.