Use Int overflow polyfill for Swift <3.2, not just Swift <4.0

bignerdranch / Freddy

A reusable framework for parsing JSON in Swift.

MIT License

1.09k stars 120 forks source link

Use Int overflow polyfill for Swift <3.2, not just Swift <4.0 #253

Closed abijlani closed 7 years ago

abijlani commented 7 years ago

The extension on Int has a Swift version check which assumes version 4.0, however, we did not anticipate version 3.2. To compile Freddy without upgrading to 4.0 and keeping with Swift 3.2 we need to make sure version check on the Int takes into account 3.2.

This project builds successfully with Xcode 9 and Xcode 8.3.

jeremy-w commented 7 years ago

Thanks! This seems like a shoo-in. Just gonna wait on Travis to check it's all well before merging.

abijlani commented 7 years ago

Thanks! Looks like it passed.

jeremy-w commented 7 years ago

Oops, got the direction we were filling in backwards. inequalities--