bigomics / playbase

Core back-end functionality and logic for OmicsPlayground
Other
4 stars 0 forks source link

Improve handling of invalid comparison names #105

Closed mauromiguelm closed 5 months ago

mauromiguelm commented 7 months ago

this fixes https://github.com/bigomics/omicsplayground/issues/916

This pull request changes the behavior of how pgx checks handle invalid comparison names. Previously, the affected comparisons were removed from the file. and now we request an action from the user.

This fix comes from an user that had two comparisons, one was invalid, proceeded to computation, and then could not find the removed comparison in the results. The user was frustated.

After the fix, we will have a pgx check failure, not a warning: image