search

bigomics / playbase

Core back-end functionality and logic for OmicsPlayground
Other
3 stars 0 forks source link

Remove unnecessary guess_organism check and dbg #107

Closed mauromiguelm closed 4 months ago

mauromiguelm commented 4 months ago

Requires new upload, where choosing organism is mandatory. In old upload, that step can be skipped sometimes.

This pull request removes the unnecessary guess_organism check from the code. It also adds a check for a null organism and throws an error if it is null, as organism should never be null.

This fixes the issue where guess_organism was returning two organisms (rat, mouse) when probes were very similar (30% threshold), and crashing computation.

[createPGX] creating pgx object...
[guess_organism] auto-detected organism = MouseRat
Error in if (tolower(organism) != tolower(guess_organism)) { : 
  the condition has length > 1
mauromiguelm commented 4 months ago

this was done in duplicated in annotation