bigomics / playbase

Core back-end functionality and logic for OmicsPlayground
Other
4 stars 0 forks source link

Fix #1139: spearman crashes on SA proteomics data (no remove of features without symbol) #160

Closed ESCRI11 closed 2 months ago

ESCRI11 commented 2 months ago

This closes https://github.com/bigomics/omicsplayground/issues/1139

Description

When some symbol was missing, this crashed because it tried to subset the NA element which does not exist.

Looking at the code we can see that actually G is subsetted by the rownames of X(https://github.com/bigomics/playbase/blob/main/R/gset-meta.r#L84), and xx1 comes from X(https://github.com/bigomics/playbase/blob/main/R/gset-meta.r#L90); therefore intersecting rownames of G and xx1 will always be the same.