search

bigorangemachine / ksp-kronalutils

The Unlicense
19 stars 10 forks source link

Quick & Dirty fix for semi-transparent parts (Issue #21) #23

Closed fingerboxes closed 9 years ago

fingerboxes commented 9 years ago

Loads the modified shaders when rendering the vessel view, unloads them afterward. Not super efficient, but works, and I didn't notice any performance issues.

bigorangemachine commented 9 years ago

@fingerboxes I apologize in my delay (life of a freelancer).

I normally insist people use the dev-master version for contributions but I don't mind running a diff on it.

I will release it as a pre-release; I am very busy and I will test this when I have time.

fingerboxes commented 9 years ago

I can resubmit against dev-master, if you want. Fix is pretty simple, just applies and removes custom shaders from parts at the beginning and end of rendering the vv image On Nov 27, 2014 6:25 PM, "bigorangemachine" notifications@github.com wrote:

@fingerboxes https://github.com/fingerboxes I apologize in my delay (life of a freelancer).

I normally insist people use the dev-master version for contributions but I don't mind running a diff on it.

I will release it as a pre-release; I am very busy and I will test this when I have time.

— Reply to this email directly or view it on GitHub https://github.com/bigorangemachine/ksp-kronalutils/pull/23#issuecomment-64842484 .

bigorangemachine commented 9 years ago

Ya I can see that. Just always test :) Don't worry about resubmitting.

I can't replicate the issue with the transparent parts. Do you have to be in space for them to go transparent?

fingerboxes commented 9 years ago

No, but it only happens on some parts. Science Jr was the one I tested against On Nov 27, 2014 6:52 PM, "bigorangemachine" notifications@github.com wrote:

Ya I can see that. Just always test :)

I can't replicate the issue with the transparent parts. Do you have to be in space for them to go transparent?

— Reply to this email directly or view it on GitHub https://github.com/bigorangemachine/ksp-kronalutils/pull/23#issuecomment-64844026 .

bigorangemachine commented 9 years ago

Are you running on open gl mode? What OS?

fingerboxes commented 9 years ago

Yes, opengl. Win32 On Nov 27, 2014 7:22 PM, "bigorangemachine" notifications@github.com wrote:

Are you running on open gl mode? What OS?

— Reply to this email directly or view it on GitHub https://github.com/bigorangemachine/ksp-kronalutils/pull/23#issuecomment-64845846 .

bigorangemachine commented 9 years ago

There seems to be instabilities with this build and Mod Manger 2.5.2 when using WIN 64 bit (no OpenGL) as promised its released as a pre-release.

I wasn't able to confirm the original issue. I'm sure its a circumstance with a driver or such.

Will include it in the future master-branch

bigorangemachine commented 9 years ago

Changes included in current build.

Trying to close this pull request correctly.