bigorangemachine / ksp-kronalutils

The Unlicense
19 stars 10 forks source link

Up/down rotation fails if root part rotated (VAB) #24

Open wisq opened 9 years ago

wisq commented 9 years ago

I tend to rotate my ships 90 degrees to face east for takeoff, and this confuses KVV. The up/down rotation buttons appear to do nothing, and I thought maybe they were deliberately disabled or throwing exceptions, but now I think it's just that KVV gets the axes wrong and is "rotating" but doing nothing.

Reproduceable by taking a command pod and rotating it ninety degrees (either way). May need to save+load to reinit KVV. Definitely does not work if you load a 90-rotated ship, but seems to be okay if I rotate the ship after loading, before starting KVV.

bigorangemachine commented 9 years ago

@wisq , Thanks for the bug report. Could you send me a craft file? Are you updated to the newest version of KVV? The 0.25 is not compatible with the 0.90 version.

I recently tested the controls when I did the patch I didn't notice anything weird. I think it might make more sense if I see what you are working with.

wisq commented 9 years ago

Okay, will investigate this tonight. From memory, my experience was that I could lay down a command pod, rotate it with Q/E, fire up KVV, and left/right rotation would work but up/down would do nothing. But I'll confirm the specifics and attach a craft file of an affected vessel.

wisq commented 9 years ago

Okay, so the above is correct.

Craft file: https://dl.dropboxusercontent.com/u/32378574/KVV%20unable%20to%20rotate.craft

YouTube video of bug being reproduced: https://www.youtube.com/watch?v=UdvnUlzaoFo

And a second ship, the one I attached:

Not shown:

wisq commented 9 years ago

Oh, and, modlist available on demand, but it's 80+ long, so I'm not including it unless you want it. :)

wisq commented 9 years ago

Oh. It occurs to me that I never did actually confirm I have your version of the mod and not just some other random version. Is yours the one that's on CKAN?

bigorangemachine commented 9 years ago

@wisq , THANKS for the detail! That video is very helpful

CKAN? No I haven't submitted to CKAN yet. It might be pulling the Kerbal Stuff Page. It is possible that CKAN is not installing it correctly. However it'd cause it not to work at all.

I'm sure its a legit bug. I've been suspecting there are glitches because of the new gizmo system.

wisq commented 9 years ago

(oops, posted with my work account, heh — reposting with right account to keep things sane)

Cool, glad to help.

It mainly only seems to affect ships that face east/west, but facing north/south seems fine. Or at least, I think that's the case. What I know for certain is that ships default to facing north and I default them facing east because, well, easterly orbits are the normal way. And KVV doesn't like my eastern rockets, but is perfectly happy once I turn them north (and south, too, I think).

Anyway, once I figured out the problem, it was pretty easy to just rotate them before taking top/bottom shots. I've been using KVV shots extensively in my blog series (e.g. http://wisq.net/2015/01/04/kadet-3/ ) and loving them.