search

bigorangemachine / ksp_js_career_sci_list

Kerbal Space Program - JavaScript Save File Reader - Career Checklist Generator
http://bigorangemachine.github.io/ksp_js_career_sci_list
Apache License 2.0
19 stars 7 forks source link

SCANsat support #1

Open mathuin opened 9 years ago

mathuin commented 9 years ago

https://github.com/S-C-A-N/SCANsat

It's a fun mod that adds new parts which have different scanning capabilities. Science is generated as a result, and the science list tool gets a little confused.

I can provide persistent.sfs files with relevant data if that helps.

bigorangemachine commented 9 years ago

Hey Please provide the sfs file.

mathuin commented 9 years ago

https://gist.github.com/mathuin/369c3a5d1bc427847f57

bigorangemachine commented 9 years ago

I'm not too sure what you are expecting to see.

The ScanSat is added to the tool. As you do science on more rails it'll pick it up. I see what you mean that maybe a little confusing because it seems to only pick up one biome. I don't use ScanSat myself so I'm not sure how it can be effectively added.

Are you suggesting there should be a separate table? Or that the output of the table doesn't match how scan sat is actually used?

mathuin commented 9 years ago

Sorry it took me so long to respond -- I finally got my PC back with the game. :-)

The page is organized first by location, then by situation, then by biome, followed by "instrument".

As an example, that file shows 94.67% completion for the mystery goo instrument in the biome "Mission Control" located on the surface of Kerbin. So far, so good.

The SCANsat data is rendered by the page by adding a fake biome "surface" to every situation at every location. Additionally, an instrument "SCANsatAltimetryLoRes" is added in this file. Any science collected by the low-resolution altimetry sensor (the only instrument I've used) is recorded in the fake biome "surface" in the situation "SpaceHigh" for the relevant location. In this example, 80% of Kerbin has been surveyed by the instrument, 100% of Mun, and 90.97% of Minmus.

I do not think adding the fake biome "surface" to all the things is a good idea. Unfortunately, I don't have many good ideas. :-) One suggestion would be a situation-wide bar (like those used for vessel recovery and other instruments) or maybe a location-wide bar for each SCANsat instrument. It all depends on what the other instruments do, to be honest. This is the only instrument I've used -- I am hoping someone else can contribute an sfs file with more instruments so we can see what they do, but I suspect they do the same.

What do you think?

mathuin commented 8 years ago

I might have time this summer to add support for this mod, and if it turns out to be not too difficult, I might try to add support for Kerbalism as well. That one is more complex, but SCANsat seems pretty straightforward.

Is it worth trying to implement this myself? Would you accept a PR if I sent it?