search

bigpipe / bigpipe.js

The client-side library which is used in BigPipe to orchestrate the pagelets.
MIT License
20 stars 6 forks source link

Should childs re-render when parents render #8

Open 3rd-Eden opened 10 years ago

3rd-Eden commented 10 years ago

Currently when you parent pagelet and it re-renders the layout the childs will not re-render. This needs to be done manually. It might make more sense to have the child pagelets listen to parent's render event and trigger a render after that.

As an additional optimization we could be given the new DOM tree, and modify that before it's added to the root element of the parent node so we have to do less DOM manipulation. Of course this wouldn't be needed if we adopted something like a shadow/virtual dom.

3rd-Eden commented 10 years ago

First part was fixed with: https://github.com/bigpipe/bigpipe.js/commit/cbb31ebf33b3ad0abe22d6d7abb217b9b3e7c8c5