search

bigpresh / Business-Tax-VAT-Validation

Business::Tax::VAT::Validation - a Perl module to validate EU VAT numbers
GNU General Public License v3.0
1 stars 5 forks source link

EU has changed their SOAP endpoint? "The given SOAPAction http://www.w3.org/2003/05/soap-envelope does not match an operation" #12

Closed tswfi closed 3 years ago

tswfi commented 3 years ago

Got some reports from our customers that VATID checks were only doing local checks.

cloned the master branch and tested with the example cli script.

$ perl -I ../lib vat_cli.pl FI22486726
Error 257 : Invalid response, please contact the author of this module. <soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/"><soap:Body><soap:Fault><faultcode>soap:Server</faultcode><faultstring>The given SOAPAction http://www.w3.org/2003/05/soap-envelope does not match an operation.</faultstring></soap:Fault></soap:Body></soap:Envelope>

Tried to find some changelog type thing from EU site but could not find any.

But these two pages point to different wsdl files: https://ec.europa.eu/taxation_customs/vies/technicalInformation.html https://ec.europa.eu/taxation_customs/vies/faq.html#item_18

bigpresh commented 3 years ago

Hmm, yes, I can confirm the same behaviour from here.

I'm unlikely to have time to do much with this for a while, I've not got a lot of free time, and I don't use this code in my paid work any more (at my previous employer we relied on it, so I'd have been able to spend paid work time fixing it).

I'm quite happy to accept PRs fixing it, and also not at all averse to the idea of handing over maintainership of the module to someone else who has the time and desire to fight SOAP and the EU's APIs.

tswfi commented 3 years ago

Made a PR for this. Seems to work for me, but I don't have a way of running a full test suite right now.

Kinda busy also so I won't be able to take any maintainership on this.

Perhaps adding a note in the readme would help finding a maintainer with more time? Just a simple "We are searching for new maintainers" notification on top of the readme?

bigpresh commented 3 years ago

Nice one - good to see it turned out to be a pretty easy fix :)

Tested locally with a known EU VAT number and it now works with this change, so all looks good.

Regarding maintainership - I could use the standard PAUSE way of give perms to the "ADOPTME" user to flag it as looking for a new maintainer - I'll do that at some point soon.

Thanks for the fix!

bigpresh commented 3 years ago

1.21 is on its way to CPAN with this fix now.