search

bigpresh / Dancer-Plugin-Database

Dancer::Plugin::Database - easy database support for Dancer applications
http://search.cpan.org/dist/Dancer-Plugin-Database
37 stars 36 forks source link

Added disconnect method (database->disconnect for example) and added .git #10

Closed Perlover closed 12 years ago

Perlover commented 12 years ago

I don't test it but i think it will work make test passed Soon i will use my commit in my project If you will decide that code is OK, you can wait my own tests in real project and i will let you know result. May be you will create now a separately branch for this now? :)

bigpresh commented 12 years ago

Thanks for the pull request! I'll have a bit more of a think about it, but my initial impression is that the tweak of simply checking for $dbh->{Active} before returning a handle from the database() keyword would probably be an easier and more elegant solution, and would handle any other cases where the database handle became inactive for any reason.

bigpresh commented 12 years ago

Closing this PR, as the other PR using the $dbh->{Active} check is merged.