bigpresh
commented
11 years ago Weird. At first glance, that fix makes no sense to me - it does not look like it ought to fix the problem.
You're sure that it was fixed by that, and isn't just an intermittent failure that sometimes fails, sometimes doesn't?
I'm willing to incorporate the fix either way as it's safe, but it just feels weird to me - off the top of my head, the lack of params should only matter if var hasn't yet been defined by that point, but it has (if it hadn't, I'd expect a compilation failure, not incorrect behaviour).
wchristian
sdeseille
Hello
I found a little problem by compiling last version of 'Dancer-Plugin-Database' with Strawberry Perl on MS Windows. I have a very little patch to solve it. ;)
Below my report :
cpanm (App::cpanminus) 1.5006 on perl 5.012003 built for MSWin32-x86-multi-thread Work directory is /.cpanm/work/1349380882.648 You have make D:\Strawberry\c\bin\dmake.exe You have LWP 6.02 Falling back to Archive::Tar 1.76 Searching Dancer::Plugin::Database on cpanmetadb ... --> Working on Dancer::Plugin::Database Fetching http://search.cpan.org/CPAN/authors/id/B/BI/BIGPRESH/Dancer-Plugin-Database-2.01.tar.gz -> OK Unpacking Dancer-Plugin-Database-2.01.tar.gz Entering Dancer-Plugin-Database-2.01 Checking configure dependencies from META.yml Checking if you have ExtUtils::MakeMaker 0 ... Yes (6.62) Configuring Dancer-Plugin-Database-2.01 Running Makefile.PL Checking if your kit is complete... Looks good Writing Makefile for Dancer::Plugin::Database -> OK Finding PREREQ from Makefile ... Checking if you have Test::More 0 ... Yes (0.98) Checking if you have Dancer 1.3099 ... Yes (1.3100) Checking if you have DBI 0 ... Yes (1.616) Building and testing Dancer-Plugin-Database-2.01 cp lib/Dancer/Plugin/Database.pm blib\lib\Dancer\Plugin\Database.pm cp lib/Dancer/Plugin/Database/Handle.pm blib\lib\Dancer\Plugin\Database\Handle.pm D:\Strawberry\perl\bin\perl.exe "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib\lib', 'blib\arch')" t/*.t
Testing Dancer::Plugin::Database 2.01, with Dancer 1.31 in Perl 5.012003, D:\STRAWB~1\perl\bin\perl.exe
t/00-load.t ....... ok
Failed test 'database_connection_failed hook fires'
at t/01-basic.t line 174.
got: ''
expected: '1'
Looks like you failed 1 test of 41.
t/01-basic.t ...... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/41 subtests
Testing Dancer::Plugin::Database::Handle 0.12, Perl 5.012003, D:\STRAWB~1\perl\bin\perl.exe
t/02-handle.t ..... ok t/manifest.t ...... skipped: Author tests not required for installation t/pod-coverage.t .. ok t/pod.t ........... ok
Test Summary Report
t/01-basic.t (Wstat: 256 Tests: 41 Failed: 1) Failed test: 41 Non-zero exit status: 1 Files=6, Tests=52, 4 wallclock secs ( 0.13 usr + 0.02 sys = 0.14 CPU) Result: FAIL Failed 1/6 test programs. 1/52 subtests failed. dmake.exe: Error code 255, while making 'test_dynamic' -> FAIL Installing Dancer::Plugin::Database failed. See .cpanm\build.log for details. Expiring 13 work directories.
Below my patch
Edit file TestApp.pm
replace line : return var 'connection_failed';
by line : return var('connection_failed');
Below my result
C:.cpanm\work\1349380882.648\Dancer-Plugin-Database-2.01>dmake test D:\Strawberry\perl\bin\perl.exe "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib\lib', 'blib\arch')" t/*.t t/00-load.t ....... 1/1 # Testing Dancer::Plugin::Database 2.01, with Dancer 1.3 1 in Perl 5.012003, D:\STRAWB~1\perl\bin\perl.exe t/00-load.t ....... ok t/01-basic.t ...... ok t/02-handle.t ..... # Testing Dancer::Plugin::Database::Handle 0.12, Perl 5.0120 03, D:\STRAWB~1\perl\bin\perl.exe t/02-handle.t ..... ok t/manifest.t ...... skipped: Author tests not required for installation t/pod-coverage.t .. ok t/pod.t ........... ok All tests successful. Files=6, Tests=52, 3 wallclock secs ( 0.06 usr + 0.09 sys = 0.16 CPU) Result: PASS