factor out _generate_where_clauses for

bigpresh / Dancer-Plugin-Database

Dancer::Plugin::Database - easy database support for Dancer applications

http://search.cpan.org/dist/Dancer-Plugin-Database

37 stars 36 forks source link

factor out _generate_where_clauses for #87

Closed joshrabinowitz closed 7 years ago

joshrabinowitz commented 7 years ago

https://github.com/bigpresh/Dancer-Plugin-SimpleCRUD/pull/57 For discussion @bigpresh

ambs commented 7 years ago

Looks good. Let me know if you want a merge and release, @bigpresh (of course you can do it yourself too :))

joshrabinowitz commented 7 years ago

awesome, thanks for the quick review, ambs

bigpresh commented 7 years ago

At a quick skim-over it looks sane, other than a couple of tiny niggles, but I'd like to re-review it tomorrow with fresh eyes before I merge and release.

joshrabinowitz commented 7 years ago

@bigpresh - repushed with your input integrated.

bigpresh commented 7 years ago

Merged, and D::P::D::Core 0.15 released - thanks Josh!