search

bigretromike / nakamori

Nakamori is Kodi addon that use Shoko (known as Japanese Media Manager (JMM)) Server as back-end for metadata information.
https://shokunin.monogatari.pl/nakamori/
49 stars 5 forks source link

Nancy 1.x doesn't support asynchronous requests #204

Closed da3dsoul closed 7 years ago

da3dsoul commented 7 years ago

Due to that, file offset and trakt syncing just time out.

da3dsoul commented 7 years ago

The solution to this is to capture the progress and only send it after the video is stopped.

bigretromike commented 7 years ago

sure ? I remamber that trying it with fiddle And if I spam it with requests I still got all them done correctly

bigretromike commented 7 years ago

I will look it up at weekend then; solution would be make 1 api call for both things, until we migrate to Nancy2.0 if its really the case

bigretromike commented 7 years ago

OK, I tested. Nancy in latest stable version ( 3.7.0.6) is async. If its not they someone f***ed it up. I can spam it with 10 x ALL, 10x series_all, 10xepi_info I get all quick request respond then I get the slower ones...

bigretromike commented 7 years ago

also: https://github.com/NancyFx/Nancy/wiki/Async

da3dsoul commented 7 years ago

You didn't notice I wrote that latest commit that made Nancy requests async? I found that article and fixed it, so yes it works now.

da3dsoul commented 7 years ago

They are not async in latest stable. Easy way to tell, play a file in Kodi, then start issuing requests in fiddler.

bigretromike commented 7 years ago

Strange as I tested with version that I posted above and it looks as async, maybe the problem is not async but the quantity of request ? maybe we should slow them down ?

da3dsoul commented 7 years ago

No it's fine to close this, as it will be fixed in the next release of shoko. I was just pointing it out. I happened to notice because halfway through a show I started getting a bunch of timeout notices

bigretromike commented 7 years ago

hmmm then im thinking it was also a timeout (full quote) problem. This could be tested on one point...

anyway, any eta for shoko? or its still 2018 ?:-)

da3dsoul commented 7 years ago

It's getting there. avael came back and started doing some much needed work on desktop. You might interested in https://github.com/japanesemediamanager/shokoserver/issues/545

bigretromike commented 7 years ago

Look nice

On April 14, 2017 2:55:22 PM GMT+02:00, da3dsoul notifications@github.com wrote:

It's getting there. avael came back and started doing some much needed work on desktop. You might interested in github.com/japanesemediamanager/shokoserver/issues/545

-- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/bigretromike/nakamori/issues/204#issuecomment-294149018