Removing deprecated behaviour

[bigretromike]

RunScript called for a non-script addon 'plugin.video.nakamori'. This behaviour is deprecated.

While investigating into my audio problem and looking up logs I came across this one. We could move some code into script/service addon.

[da3dsoul]

What version?

[da3dsoul]

That doesn't exist in latest

[bigretromike]

2.1.18

[bigretromike]

maybe you test on different settings than me and mine does something that your dont

[da3dsoul]

No I legitimately just got Ctrl+f and RunScript doesn't exist

[bigretromike]

strange.... because I dont use other plugins...

[bigretromike]

This is log from yesterday night

21:45:30.667 T:4772  NOTICE: DXVA::CDecoder::Close - closing decoder
21:45:30.667 T:4772  NOTICE: DXVA::Close - closing decoder context
21:45:30.698 T:4772  NOTICE: CDVDVideoCodecFFmpeg::Open() Using codec: HEVC (High Efficiency Video Coding)
21:45:31.105 T:4772  NOTICE: CDVDVideoCodecFFmpeg::CDropControl: calculated diff time: 41727
21:46:36.711 T:2568  NOTICE: ES: Client  from ::ffff:10.2.1.13 timed out
22:05:22.679 T:4012   ERROR: Control 55 in window 10025 has been asked to focus, but it can't
22:05:22.679 T:4012  NOTICE: CVideoPlayer::CloseFile()
22:05:22.679 T:4012  NOTICE: VideoPlayer: waiting for threads to exit
22:05:22.686 T:424  NOTICE: CVideoPlayer::OnExit()
22:05:22.686 T:424  NOTICE: Closing stream player 1
22:05:22.686 T:424  NOTICE: Waiting for audio thread to exit
22:05:22.726 T:3968  NOTICE: thread end: CVideoPlayerAudio::OnExit()
22:05:22.726 T:424  NOTICE: Closing audio device
22:05:22.777 T:424  NOTICE: Deleting audio codec
22:05:22.777 T:424  NOTICE: Closing stream player 2
22:05:22.777 T:424  NOTICE: waiting for video thread to exit
22:05:22.812 T:4772  NOTICE: thread end: video_thread
22:05:22.812 T:424  NOTICE: deleting video codec
22:05:22.827 T:424  NOTICE: Closing stream player 3
22:05:22.866 T:4012  NOTICE: VideoPlayer: finished waiting
22:05:22.971 T:4012  NOTICE: CVideoPlayer::CloseFile()
22:05:22.971 T:4012  NOTICE: VideoPlayer: waiting for threads to exit
22:05:22.971 T:4012  NOTICE: VideoPlayer: finished waiting
22:05:22.971 T:4012  NOTICE: CVideoPlayer::CloseFile()
22:05:22.971 T:4012  NOTICE: VideoPlayer: waiting for threads to exit
22:05:22.971 T:4012  NOTICE: VideoPlayer: finished waiting
22:05:24.322 T:1084   ERROR: EXCEPTION: XBMC is not playing any media file
22:05:33.070 T:4012 WARNING: RunScript called for a non-script addon 'plugin.video.nakamori'. This behaviour is deprecated.
22:05:40.306 T:4012  NOTICE: VideoPlayer: Opening: G:\anime\anime\Shokugeki no Souma\[Cleo]Shokugeki_no_Souma_-_12_(10bit_BD720p_x265).mkv
22:05:40.306 T:4012 WARNING: CDVDMessageQueue(player)::Put MSGQ_NOT_INITIALIZED
22:05:40.315 T:2924  NOTICE: Creating InputStream
22:05:40.318 T:2924  NOTICE: Creating Demuxer
22:05:40.391 T:2924  NOTICE: Opening stream: 0 source: 256
22:05:40.391 T:2924  NOTICE: Creating video codec with codec id: 174

One episode after another, I'm not sure If I didn't vote for episode between; I see ERRORs which shouldn't be there.

This is settings.xml I use

<settings>
    <setting id="apikey" value="*******************************" />
    <setting id="context_krypton_watched" value="true" />
    <setting id="context_pick_file" value="true" />
    <setting id="context_playlist" value="true" />
    <setting id="context_show_info" value="true" />
    <setting id="context_show_play_no_watch" value="true" />
    <setting id="context_show_vote_Episode" value="true" />
    <setting id="context_show_vote_Series" value="true" />
    <setting id="device" value="nakamori" />
    <setting id="displaylang" value="en" />
    <setting id="enableCache" value="false" />
    <setting id="expireCache" value="300" />
    <setting id="file_resume" value="true" />
    <setting id="hideArtTags" value="false" />
    <setting id="hideMiscTags" value="false" />
    <setting id="hideSourceTags" value="false" />
    <setting id="hideSpoilerTags" value="false" />
    <setting id="hideUsefulMiscTags" value="false" />
    <setting id="ide_ip" value="localhost" />
    <setting id="ide_port" value="5376" />
    <setting id="ignore_specials_watched" value="false" />
    <setting id="ipaddress" value="127.0.0.1" />
    <setting id="local_total" value="false" />
    <setting id="login" value="" />
    <setting id="maxlimit" value="20" />
    <setting id="maxlimit_tag" value="100" />
    <setting id="no_mark" value="0" />
    <setting id="password" value="" />
    <setting id="pick_file" value="true" />
    <setting id="player_sleep" value="5000" />
    <setting id="port" value="8111" />
    <setting id="refresh_wait" value="1000" />
    <setting id="remote_debug" value="false" />
    <setting id="request_nocast" value="false" />
    <setting id="short_tag_list" value="true" />
    <setting id="show_continue" value="true" />
    <setting id="skipExtraInfoMaxEpisodes" value="50" />
    <setting id="skipExtraInfoOnLongSeries" value="false" />
    <setting id="spamLog" value="false" />
    <setting id="syncwatched" value="true" />
    <setting id="timeout" value="60" />
    <setting id="title_type" value="Official" />
    <setting id="trakt" value="false" />
    <setting id="trakt_scrobble" value="false" />
    <setting id="trakt_scrobble_notification" value="false" />
    <setting id="useOriginalThumbnailRatio" value="false" />
    <setting id="useSeasons" value="false" />
    <setting id="use_gzip" value="true" />
    <setting id="use_server_sort" value="false" />
    <setting id="use_server_title" value="false" />
    <setting id="vote_always" value="false" />
    <setting id="vote_on_series" value="false" />
    <setting id="watched_mark" value="80" />
    <setting id="watchedbox" value="true" />
</settings> 

[bigretromike]

My bad its 2.1.17