bigretromike / nakamori

Nakamori is Kodi addon that use Shoko (known as Japanese Media Manager (JMM)) Server as back-end for metadata information.
https://shokunin.monogatari.pl/nakamori/
49 stars 5 forks source link

opt-in: what you use statistic #236

Closed bigretromike closed 5 years ago

bigretromike commented 6 years ago

Ability to send option/configuration - optional, disable by default; So we will know if anyone use those no-needed function that I add

bigretromike commented 6 years ago

nakamori-modules-version kodi-version settings.xml without apikey I think there is nothing more needed to be honest. OS is not important that much. settings would tell use if there is 'common' default settings that everybody use, and we could know focus on building around those.

I'm thinking about counter to cross that with settings like each enter into calendar would increased counter for 'calendar-use' and that would indicate if someone is having it in menu because he use it or not and left it as default.

What do you think about this @da3dsoul, all is good? half of it is good? none of it is good?

da3dsoul commented 6 years ago

Honestly, I think this is better in Server. I'd prefer to know what server features are used most so that we can make Nakamori's UI more intuitive for a normal user. If people like group filters, focus on better filter support, such as adding, editing, and show/hiding them. If people use search a lot, they we can improve the search UI immensely. Etc

da3dsoul commented 6 years ago

I could implement trackers and analytics into the API back end, and then the network activity is focused on Server where it should be.

da3dsoul commented 6 years ago

I've wanted some analytics for a while, but we need a place to store it as well as proper opt out/in and whatnot

bigretromike commented 6 years ago

So you are fine with data usage but you prefer them being in server, so we just api/something?=nakamori, and you will know that it was from nakamori and not desktop? But then you would have to send them somewhere from server, and how we other developers (or me) check that data ? would they be public accessible ? I see your point and shoko would benefit like hell from it, but still that don't resolve any question like 'do people use x or y ?' but ok. I will leave this as-is. Wont rush it to 3.0.0 then

da3dsoul commented 6 years ago

You seem to forget that I'm kind of the current lead dev of Shoko, and I would be able to access and deliver/give access to you if needed. Also, when Kodi asks for things from the API, it has a header that says, "hey I'm Nakamori", so that's not an issue either.

da3dsoul commented 6 years ago

https://github.com/bigretromike/nakamori/blob/master/resources/lib/util.py#L119

da3dsoul commented 6 years ago

We just need to pass that, and server will know

bigretromike commented 6 years ago

I know, but thats 17.x thing ;p

bigretromike commented 6 years ago

also do you still use that old debugger of your in nakamori ? because Im replacing it with something ultra easy to use

da3dsoul commented 6 years ago

Before that, we get Mozilla. No one but nakamori calls with Firefox

da3dsoul commented 6 years ago

No you can remove it

da3dsoul commented 5 years ago

We have Google Analytics now. It's just a matter of implementing it. This could be done for APIv2, but it would be pointless, so waiting for APIv3 is the better idea

bigretromike commented 5 years ago

No thanks, I wont forward user data to place where is muliply people have access, you don't need to worry about this 😃

On March 12, 2019 7:41:06 PM GMT+01:00, da3dsoul notifications@github.com wrote:

We have Google Analytics now. It's just a matter of implementing it. This could be done for APIv2, but it would be pointless, so waiting for APIv3 is the better idea

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/bigretromike/nakamori/issues/236#issuecomment-472131119

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

da3dsoul commented 5 years ago

It's anonymous. You are identified as some guy from Poland, or so we think...you could be a VPN user! It's about stats. We are using it to track ban counts and various things like that.

bigretromike commented 5 years ago

I don't need Google analitics here 😃 so please don't enforce it.

On March 12, 2019 7:48:07 PM GMT+01:00, da3dsoul notifications@github.com wrote:

It's anonymous. You are identified as some guy from Poland, or so we think...you could be a VPN user! It's about stats. We are using it to track ban counts and various things like that.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/bigretromike/nakamori/issues/236#issuecomment-472133686

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

da3dsoul commented 5 years ago

Well, we wouldn't enforce it. It opt-out easily, and it collects basically nothing.

bigretromike commented 5 years ago

You miss the point, will DM you later about it

On March 12, 2019 7:51:33 PM GMT+01:00, da3dsoul notifications@github.com wrote:

Well, we wouldn't enforce it. It opt-out easily, and it collects basically nothing.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/bigretromike/nakamori/issues/236#issuecomment-472134885

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

da3dsoul commented 5 years ago

mk. It's whatever. You know I don't really care either way.

da3dsoul commented 5 years ago

We aren't secretive about stuff, nor do we gather anything important. It is kind of cool to see, though. image image image

da3dsoul commented 5 years ago

Those are basically the only windows that have any data. We don't give it anything except event and a session ID to distinguish that the user is unique.

da3dsoul commented 5 years ago

That's useful because we have a lot of new users who start server, see that it's not simple, close it, and leave. That means that our first time setup experience could use work. I'm not too worried about them, as patience is needed to get started with Shoko.

bigretromike commented 5 years ago

testing in progress...