Before releasing 3.x

[da3dsoul]

The structure I'm thinking for settings is:

Tabs:
    General - Connection, Login Status, Login Wizard
    Browsing - Settings for browsing, Tag Filter
    Video - playback, scrobbling
    Search
    Calendar
    Advanced

There are some settings that are to be removed or changed, as well. Select first unwatched is a Kodi setting, so it's unnecessary. Skip info on long series is not needed, as the API has gotten major improvements. Rather than having Calendar and v2, make it just Calendar, and have a setting in the calendar section to use the new calendar style. For hiding ratings, make it a combo box, and link the cases to it.

It doesn't even work for me. I can't get past the main screen, as it says no connection, despite passing the test. The new connection box is also hideous. The old one wasn't beautiful, but it was fine.

New versions of Shoko have a init/status endpoint, which we can use to tell if the server is running. It does not need auth. We need to be using it. This endpoint will respond even if the server is still starting, and it will give the startup message as well as error if one happened. We can use this to wait and report startup status, as well as give better info than "I don't know server isn't responding"

The first time setup needs work. The proper way to deal with first time setup is:

1. Check for server status at localhost, if yes go to 3, if no go to 2
2. Prompt for server address, depending on return, give info or continue to 3
3. Prompt for user, filling in Default userpass for the user
4. Give a message saying that various options exist in the addon settings
5. show the main menu

Maybe more, we'll see when it actually starts

[da3dsoul]

It worked https://github.com/bigretromike/nakamori/commit/5c33770943f4a5f6761526e1a8eb77e110bf518a

Judging from the commits, it was probably the latest commit that broke it

[bigretromike]

About 'select first' that option is so hard to find in current kodi that I would keep our option. New endpoint? Never heard of those hahah. Calendar switching yes and no but I can go with your idea. For hiding ratings, there is combo box for options. I know new connection test don't look great but its image based so it should be hard to fix it. Strange it didn't work for you, probably you missing depended library that is needed for script module which will install automaticly when it will be in repo.

On August 31, 2018 4:39:02 AM GMT+02:00, da3dsoul notifications@github.com wrote:

The structure I'm thinking for settings is:

Tabs:
   General - Connection, Login Status, Login Wizard
   Browsing - Settings for browsing, Tag Filter
   Video - playback, scrobbling
   Search
   Calendar
   Advanced

There are some settings that are to be removed or changed, as well. Select first unwatched is a Kodi setting, so it's unnecessary. Skip info on long series is not needed, as the API has gotten major improvements. Rather than having Calendar and v2, make it just Calendar, and have a setting in the calendar section to use the new calendar style. For hiding ratings, make it a combo box, and link the cases to it.

It doesn't even work for me. I can't get past the main screen, as it says no connection, despite passing the test. The new connection box is also hideous. The old one wasn't beautiful, but it was fine.

New versions of Shoko have a init/status endpoint, which we can use to tell if the server is running. It does not need auth. We need to be using it.

The first time setup needs work. The proper way to deal with first time setup is:

1. Check for server status at localhost, if yes go to 3, if no go to 2
2. Prompt for server address, depending on return, give info or continue to 3
3. Prompt for user, filling in Default userpass for the user
4. Give a message saying that various options exist in the addon settings
5. show the main menu

Maybe more, we'll see when it actually starts

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/bigretromike/nakamori/issues/261

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[bigretromike]

Tabs you mentions look good but in that configuration im not sure where to put stuffs. Well free to commit new structure.

On August 31, 2018 4:39:02 AM GMT+02:00, da3dsoul notifications@github.com wrote:

The structure I'm thinking for settings is:

Tabs:
   General - Connection, Login Status, Login Wizard
   Browsing - Settings for browsing, Tag Filter
   Video - playback, scrobbling
   Search
   Calendar
   Advanced

There are some settings that are to be removed or changed, as well. Select first unwatched is a Kodi setting, so it's unnecessary. Skip info on long series is not needed, as the API has gotten major improvements. Rather than having Calendar and v2, make it just Calendar, and have a setting in the calendar section to use the new calendar style. For hiding ratings, make it a combo box, and link the cases to it.

It doesn't even work for me. I can't get past the main screen, as it says no connection, despite passing the test. The new connection box is also hideous. The old one wasn't beautiful, but it was fine.

New versions of Shoko have a init/status endpoint, which we can use to tell if the server is running. It does not need auth. We need to be using it.

The first time setup needs work. The proper way to deal with first time setup is:

1. Check for server status at localhost, if yes go to 3, if no go to 2
2. Prompt for server address, depending on return, give info or continue to 3
3. Prompt for user, filling in Default userpass for the user
4. Give a message saying that various options exist in the addon settings
5. show the main menu

Maybe more, we'll see when it actually starts

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/bigretromike/nakamori/issues/261

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[bigretromike]

Check script.module.nakamori addon.xml for needed libs.

On August 31, 2018 5:12:24 AM GMT+02:00, da3dsoul notifications@github.com wrote:

It worked https://github.com/bigretromike/nakamori/commit/5c33770943f4a5f6761526e1a8eb77e110bf518a

Judging from the commits, it was probably the latest commit that broke it

-- You are receiving this because you were assigned. Reply to this email directly or view it on GitHub: https://github.com/bigretromike/nakamori/issues/261#issuecomment-417538269

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[bigretromike]

        <import addon="script.module.pil"/>
        <!-- currently needed, but for how long we will see -->
        <import addon="script.module.kodi65" version="1.2.1"/>
        <!-- 2.25 is needed for routing -->
        <import addon="xbmc.python" version="2.25.0" />
        <import addon="script.module.routing" version="0.1.0"/>
        <!-- soon to be deprecated -->
        <import addon="script.module.pyxbmct" version="1.2.0"/>

those are needed if you installing nakamori via zip then you need manualy install those. script.module.pil in build-in Kodi (until Leia) script.module.kodi65 and script.module.routing will install if you install script.extendedinfo

There is also script.module.future from main script

[bigretromike]

I will try to cut those out kodi65/pyxbmct

[da3dsoul]

It installed everything needed. It doesn't crash, it just says no connection to server and loops the wizard, despite the wizard connecting passing

[bigretromike]

test it now - just had that problem too;

[da3dsoul]

Kk

[bigretromike]

any plans for rest of this issue @da3dsoul ?

[da3dsoul]

I'm thinking of changing your context menu hack to just put a separator and a message. As of right now, it kind of looks like a bug rather than intentional

[da3dsoul]

I think we are good now.