search

bigretromike / nakamori

Nakamori is Kodi addon that use Shoko (known as Japanese Media Manager (JMM)) Server as back-end for metadata information.
https://shokunin.monogatari.pl/nakamori/
49 stars 5 forks source link

build-in resume not working #263

Closed bigretromike closed 5 years ago

bigretromike commented 6 years ago

I just used latest build and resume dont work - when using KORE (official remote) and hiting 'enter' there is different context menu with Play and Resume. that resume don't work;

bigretromike commented 6 years ago

Also when episode is mark as halfwatched and you hit enter - you got same context menu;

da3dsoul commented 6 years ago

The only way to resume now is via context menu. We have no way of detecting when a user chooses "Resume from..." in Kodi's internal menu

da3dsoul commented 6 years ago

It's reliable if you use the context menu, which is better than the previous method, which worked about half of the time....maybe

bigretromike commented 6 years ago

But im using context menu. We need to disable the first context menu that kodi shows and force our context menu. Because the first impresion is that resume is broken

On September 1, 2018 2:27:27 PM GMT+02:00, da3dsoul notifications@github.com wrote:

It's reliable if you use the context menu, which is better than the previous method, which worked about half of the time....maybe

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/bigretromike/nakamori/issues/263#issuecomment-417856345

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

da3dsoul commented 6 years ago

Context menu is what shows up when you press C or right click. The Start Over or Resume menu is not the context menu

bigretromike commented 6 years ago

yes and no, I would call it context menu because it is context menu, but its executed by 'Action(Select)' and not right click/C.

bigretromike commented 6 years ago

Currently the only solution is to not populate ResumeTime and use different custom parameter to offset our resume. We control the player so we can change it.

da3dsoul commented 6 years ago

You can remove resume time. StartOffset makes it start at the specified time, regardless of menu options

bigretromike commented 6 years ago

@da3dsoul if that is the true than wouldn't it break 'Play' because you first have to set 'StartOffset' and then user can pick play or resume, and if you pick play and 'StartOffset' is set it would Resume and not start from beginning

da3dsoul commented 6 years ago

Yes

da3dsoul commented 6 years ago

There's no way that I'm aware of to reliably use the built in resume feature