bigretromike / nakamori

Nakamori is Kodi addon that use Shoko (known as Japanese Media Manager (JMM)) Server as back-end for metadata information.
https://shokunin.monogatari.pl/nakamori/
49 stars 5 forks source link

Rewrite/Redesign the Setup Wizard #298

Closed da3dsoul closed 5 years ago

da3dsoul commented 5 years ago

The wizard was a great idea, and it isn't necessarily poorly designed. It doesn't work great a lot of the time, though...and it sometimes reacts poorly by having not much difference between connection error and login error. My thoughts are this: T -> True/Test Succeeded F -> False/Failed

  1. Connection Test 1T. Move on 1F. Display a message that we could not connect, then show the connection dialog
  2. Check Server Startup State 2T. Move on 2F. Wait and show a properly cancelable Progress Dialog (It won't show a progress bar, just the current state)
  3. Check for valid apikey 3T. Move on 3F. Show Login Dialog

In the settings (possibly a main menu item as well), have a Log Out button instead of the ambiguous User and Password that are blank.

bigretromike commented 5 years ago

They are empty because you can set those if something is wrong but 3step check will be better, but what will happend when you change those on shoko, you don't have connection?

On March 12, 2019 7:24:02 PM GMT+01:00, da3dsoul notifications@github.com wrote:

The wizard was a great idea, and it isn't necessarily poorly designed. It doesn't work great a lot of the time, though...and it sometimes reacts poorly by having not much difference between connection error and login error. My thoughts are this: T -> True/Test Succeeded F -> False/Failed

  1. Connection Test 1T. Move on 1F. Display a message that we could not connect, then show the connection dialog
  2. Check Server Startup State 2T. Move on 2F. Wait and show a properly cancelable Progress Dialog (It won't show a progress bar, just the current state)
  3. Check for valid apikey 3T. Move on 3F. Show Login Dialog

In the settings (possibly a main menu item as well), have a Log Out button instead of the ambiguous User and Password that are blank.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/bigretromike/nakamori/issues/298

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

da3dsoul commented 5 years ago

In that case, 1 will succeed and 3 will fail.

bigretromike commented 5 years ago
bigretromike commented 5 years ago
da3dsoul commented 5 years ago

I'll take care of it. I'm redoing the flow of the wizard, but atm it's just a stub with an error

da3dsoul commented 5 years ago

It can use a bit of testing and cleanup for more edge cases, I'm sure, but done