search

bigretromike / nakamori

Nakamori is Kodi addon that use Shoko (known as Japanese Media Manager (JMM)) Server as back-end for metadata information.
https://shokunin.monogatari.pl/nakamori/
49 stars 5 forks source link

Drop the .lib, .service, etc labels. #299

Closed da3dsoul closed 5 years ago

da3dsoul commented 5 years ago

The tags that state what part of the project an issue pertains to are unnecessary. They are useful when the project is really big, but we just don't need them. We have two developers, and we both know basically the whole code base (you may not atm since rewrite, but that'll change).

I figured I'd make this to get your input before I just nuke them without asking.

bigretromike commented 5 years ago

Which tags you want to drop?

On March 12, 2019 7:29:18 PM GMT+01:00, da3dsoul notifications@github.com wrote:

The tags that state what part of the project an issue pertains to are unnecessary. They are useful when the project is really big, but we just don't need them. We have two developers, and we both know basically the whole code base (you may not atm since rewrite, but that'll change).

I figured I'd make this to get your input before I just nuke them without asking.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/bigretromike/nakamori/issues/299

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

da3dsoul commented 5 years ago

.lib .player .plugin .resource .script .service

bigretromike commented 5 years ago

You ask for most of them and now you want to merge it? LUL

On March 12, 2019 7:49:46 PM GMT+01:00, da3dsoul notifications@github.com wrote:

.lib .player .plugin .resource .script .service

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/bigretromike/nakamori/issues/299#issuecomment-472134247

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

da3dsoul commented 5 years ago

Nah you added those ones. It's just the issue labels that I want to drop, not the submodules.

bigretromike commented 5 years ago

Oh, it make it easier if something broke in single module but if you want drop them sure but if they start be needing them I will readd the anyway

On March 12, 2019 7:55:40 PM GMT+01:00, da3dsoul notifications@github.com wrote:

Nah you added those ones. It's just the issue labels that I want to drop, not the submodules.

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/bigretromike/nakamori/issues/299#issuecomment-472136359

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

da3dsoul commented 5 years ago

Fair. It just makes the issue list so colorful that it's distracting. That's even worse when we don't actually read the labels.

bigretromike commented 5 years ago

True, true.

On March 12, 2019 7:59:24 PM GMT+01:00, da3dsoul notifications@github.com wrote:

Fair. It just makes the issue list so colorful that it's distracting. That's even worse when we don't actually read the labels.

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/bigretromike/nakamori/issues/299#issuecomment-472137671

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.