Problems with Metadata Scraping - Githubissues

bigretromike / nakamori

Nakamori is Kodi addon that use Shoko (known as Japanese Media Manager (JMM)) Server as back-end for metadata information.

https://shokunin.monogatari.pl/nakamori/

48 stars 5 forks source link

Problems with Metadata Scraping #307

Open da3dsoul opened 5 years ago

da3dsoul commented 5 years ago

This is for problems with the entire concept and how we might fix them.

The first and most glaring issue is syncing watched states. The player properly sends the watched state to server, but the next step is setting it in kodi. I suggest we look at this.
For better or worse, we don't get any of the context menus. Whether that's actually a problem...idk
We obviously don't get any control over searching and group filters. Calendar and other custom menus also won't be available from the normal kodi menus. We can obviously use the plugin as we always have for such things.
Movies work differently in Kodi than AniDB and Shoko. Movies can only have one file, which means we would need a way to translate multi-part and multi-file movies into a format that Kodi likes.
[ ] Watched state management
[ ] Movie Support

bigretromike commented 5 years ago

I already explore context menu those can be install each iteam in seperate context plugin, calendar is in script we can add it with context menu plugin 😃

On April 6, 2019 2:30:48 PM GMT+02:00, da3dsoul notifications@github.com wrote:

This is for problems with the entire concept and how we might fix them.

The first and most glaring issue is syncing watched states. The play properly sends the watched state to server, but the next step is setting it in kodi. I suggest we look at this.

[ ] - Watched state management

For better or worse, we don't get any of the context menus. Whether that's actually a problem...idk

We obviously don't get any control over searching and group filters. Calendar and other custom menus also won't be available from the normal kodi menus. We can obviously use the plugin as we always have for such things.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/bigretromike/nakamori/issues/307

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

bigretromike commented 5 years ago

[x] mimic context menu from plugin
[x] Mark Series as Un/Watched
[x] Vote (Series)
[x] Vote (Episode)
[x] Calendar (because why not)

bigretromike commented 5 years ago

We really don't have to support movies in separate way - I wouldn't mind them being in TVShows because that way we would have to make all with filters is_movie but I dont use movies Library thing in Kodi maybe its supperior in some way... hmmm.... need to check it ;p

da3dsoul commented 5 years ago

I don't know. It'll take looking into

bigretromike commented 5 years ago

2019-04-07 20:45:34.677 T:6664   ERROR: CScraperParser::Parse: Could not find scraper function GetArt
2019-04-07 20:45:34.677 T:6664   ERROR: ADDON::CScraper::Run: Unable to parse web site
2019-04-07 20:45:34.722 T:6664 WARNING: XFILE::CFileFactory::CreateLoader - unsupported protocol(plugin) in plugin://plugin.video.nakamori/tvshows/1126
2019-04-07 21:07:04.156 T:6564   ERROR: NEWADDON Invalid Date Format ""
2019-04-07 21:07:04.937 T:6664   ERROR: CScraperParser::Parse: Could not find scraper function GetArt
2019-04-07 21:07:04.937 T:6664   ERROR: ADDON::CScraper::Run: Unable to parse web site
2019-04-07 21:07:04.963 T:6664 WARNING: XFILE::CFileFactory::CreateLoader - unsupported protocol(plugin) in plugin://plugin.video.nakamori/tvshows/1591

While scanning

bigretromike commented 5 years ago

I have idea for Watched state management, if you didn't start anything leave that one for me.

The other issue is that when using scanner it don't transfer 'watched' flag to Library - is that a bug? or do we not mark files correctly in InfoTags ?

da3dsoul commented 5 years ago

We pass it, but idk if it takes it

bigretromike commented 5 years ago

No it don't - which make me wonder: does it ignore it, skip because it not set correct or is it a bug ?

da3dsoul commented 5 years ago

We definitely set it correctly

bigretromike commented 5 years ago

I updated service, and its now sync Library to Shoko. Shoko sync Library only on Import (for now)

bigretromike commented 5 years ago

Context Menu updated for Video Library;

bigretromike commented 5 years ago

While scanning:

2019-04-15 13:15:39.829 T:7140 WARNING: XFILE::CFileFactory::CreateLoader - unsupported protocol(plugin) in plugin://plugin.video.nakamori/tvshows/1
2019-04-15 13:15:39.863 T:10084  NOTICE: onNotification
2019-04-15 13:15:40.889 T:7140   ERROR: CScraperParser::Parse: Could not find scraper function GetArt
2019-04-15 13:15:40.889 T:7140   ERROR: ADDON::CScraper::Run: Unable to parse web site

da3dsoul commented 5 years ago

Didn't you post that a week ago

bigretromike commented 5 years ago

And still nothing changed xD , looks like I did. But gh working like s#!$ so I couldn't really see.

da3dsoul commented 5 years ago

Haha fair

bigretromike commented 5 years ago

All strHash are same - probably my fault after last commit, but don't see where I did an error. https://github.com/bigretromike/nakamori.plugin/commit/c6b1cdc538f97e748edf7d78d8b8263a8b355951 https://github.com/bigretromike/nakamori.lib/commit/618acc59e7d7bd2edc8ec7c3f1618e80a49683f3

That would make sense only when all data that goes to hash are empty.