bigretromike / nakamori

Nakamori is Kodi addon that use Shoko (known as Japanese Media Manager (JMM)) Server as back-end for metadata information.
https://shokunin.monogatari.pl/nakamori/
49 stars 5 forks source link

Improve Calendar UI in WindowXML mode #322

Closed bigretromike closed 5 years ago

bigretromike commented 5 years ago

I still don't like how it looks. Any suggestion will be considered.

bigretromike commented 5 years ago

@da3dsoul any suggestion or should I make it all PINK ?

da3dsoul commented 5 years ago

IDK. If you want UI design, talk to EC. He's pretty good at it.

bigretromike commented 5 years ago

when did you put down the role of making designs? You were quite good with it. I wrote here, because I counted on you ;-)

da3dsoul commented 5 years ago

I'm not really good at design itself. I'm good at pointing out flaws and suggestions for improvement. Calendars are also one of those things that I'm just not good at. If I were to design something, I'd probably just mash up ClientV2 and AniChart concepts

bigretromike commented 5 years ago

ac

da3dsoul commented 5 years ago

Yeah, I really like AniChart. I'd do some things a bit different

bigretromike commented 5 years ago

sadly anidb don't give so much description about series. also having the description that way make from 7 colums to 3 :-), I could see doing one WindowXML more so you can pick your Calendar style. But give me something to work on, if you don't want to make one. what would you change in anichart

bigretromike commented 5 years ago

abb avb

bigretromike commented 5 years ago

or you more into this AC acc

da3dsoul commented 5 years ago

The things I would change are what is shown on cards and whatnot, it'll need to be dynamic with fallbacks, as there will be info missing like you mentioned.

bigretromike commented 5 years ago

@da3dsoul which AC version you like the most? first with 3x3 or second 5x7-8

da3dsoul commented 5 years ago

The bigger cards with more info and mostly poster

bigretromike commented 5 years ago

Will do my friend, will do

bigretromike commented 5 years ago

111ac

Hows that ?

bigretromike commented 5 years ago

@da3dsoul the only issue is the size of the font - like it was before thats why I got those PIL workaround for titles (generating images instead text). For now I had to add custom fonts into default skin - which could end up in your delta skin with proper finishing of Label2 issue (which would be awesome) or I can port one script that I know where is that inject this font into ANY skin but it got wipe after each skin update (annoying but most compatible)

The smallest one from default set is the one used on titles. I will have to check this calendar on TV to be sure that its TV friendly - I don't need something that is unusable for TVs you know.

The Gradient on right is also something from skin. Which I dont' see how to disable right now.

bigretromike commented 5 years ago

Font.xml

        <font>
            <name>robo16</name>
            <filename>NotoSans-Regular.ttf</filename>
            <size>16</size>
        </font>
bigretromike commented 5 years ago

Or edited estaury!!! with fonts mod (latest Leia version) skin.estuary1.zip

da3dsoul commented 5 years ago

The biggest issues I see there are the poster squishing instead of cropping and the titles being cut off

bigretromike commented 5 years ago

posters are issue from anidb - I use same, so if they dont have it Nakamori don't have it. same goes to shoko. nothing much I can do about it. the title yeah, thats no issue.

da3dsoul commented 5 years ago

I'm referring to squished posters, not missing ones

bigretromike commented 5 years ago

And I'm referring those too. If there is a Poster Anidb use it if not they use something wider than taller. Not much I can do about it.

bigretromike commented 5 years ago

@da3dsoul 29-06-2019 https://anidb.net/perl-bin/animedb.pl?show=calendar&do=schedule&last.anime.week=26&last.anime.year=2019

same images. same dimensions

da3dsoul commented 5 years ago

Crop it. If we don't have pillow, then I can make an endpointb with cropping

bigretromike commented 5 years ago

even with external source image ? even if not sure.

to make it work with PILLOW it would be downloaded to temp and with new layout its not needed, also how you crop it when you dont detect face/title.

Go for it anyway I just move it ahead to have non hentai content there hehe

bigretromike commented 5 years ago

Also which solution you prefer for font, injecting into used skin ? or with delta skin updated ? (for both k17 and k18 version ?)

da3dsoul commented 5 years ago

You'll want to use APIv3 later. I'll handle what info is filtered (no hentai on non-hentai users). You handle how it gets displayed. I can rewrite the API code in Nakamori when it gets there, just keep in mind that some things will be organized differently and we may have better info.

da3dsoul commented 5 years ago

I prefer that we don't require a specific skin.

bigretromike commented 5 years ago

so we inject in any skin the font we want to use; any recommendation for font that support jp ?

da3dsoul commented 5 years ago

I have no clue. Roboto is a nice free font, but no clue

bigretromike commented 5 years ago

yeah, roboto was first I wanted to use but it didn't work for some reason, but I fix that but went with arial. Ok. I will make few ajustments with font, injection, make long title cut in good place, and description will have scroll that will work (maybe), but most of those from shoko are missing description and the number of episode that will be aired

bigretromike commented 5 years ago

Any buttons you want to have on those 'series boxes' ? like on AC? or we leave info about airing date on the bottom part ? I just put that to see if its on right height.

da3dsoul commented 5 years ago

We'll have buttons be context menus, as there's not much we can do, other than possibly show related series and/or more info

bigretromike commented 5 years ago

I see a lot of options: releated, info, add to wishlist, send to ... (pick anything like pushbullet etc), enter series (when something on calendar is already in your collection), cast, hide series from calendar (if needed for any reason)

bigretromike commented 5 years ago

Issue with injecting custom size/font is when you are using default skin, because that one is installed not in your addons but in base directory, so you would have A) force user to use copy of default skin B) force user to use our copy of default skin (with tweaks already in it, while updating it from time to time and checking for compatibility issues - ex. k17 this skin version, k18 that version) C) generate descriptions as image and while clicking on it dialog box come out and let you read full text in default font. If user use non default skin then its not a problem to inject our font/size.

I got that sweet injector from my senpai repository, its a bit buggy but it clear as day and night that you wont be able to edit font of default skin from inside kodi and making long ass manuals/videos just to change that is not worth it because the main goal is to be as user friendly as possible (ip + login/password) with ability to tweak everything for power users.

I will try the PILLOW method once again and check out the results - it shouldn't take THAT much space, and later I could implement garbage collection in service so the old one get wiped.

da3dsoul commented 5 years ago

We can probably read the current skin from settings, then determine the location and patch it in to whatever skin is needed

bigretromike commented 5 years ago

I will short it for you:

da3dsoul commented 5 years ago

Ah, I see. You won't have write access. We can detect that and make a patched copy....

da3dsoul commented 5 years ago

This is quickly becoming not in the scope of Nakamori. I would probably make this a separate add-on and see if they'll accept it in the main repo

bigretromike commented 5 years ago

any addon that modify any other addon (or skin) is forbidden. I will see how long it take to generate those description and if the time will be too long or the results not pleasing I will go with B) our skin with tweaks for k17 it would be easy because you set minimal python version in addon.xml so k17 wouldn't install k18 skin. and for k18 someone will have to get latest version from stable k18 each time some version get release and apply patches.

bigretromike commented 5 years ago

acv2 @da3dsoul

da3dsoul commented 5 years ago

Nice

bigretromike commented 5 years ago

I'm happy that you like it. there still a lot of cleaning and I would like to have a popup window when you click on any element of series item, with detail information (for now it could be full description) and button that would be also as a right click option.

Any idea how it should look like ?

da3dsoul commented 5 years ago

Maybe look at the extendinfo window. It's super nice

bigretromike commented 5 years ago

hahaha, did you think why I waste extra time to make it work with nakamori ?:-) hahahha

But back on the topic, its nice, but its plain. Will shoko download cast for anime in calendar ?( would be awesome but I doubt) I could make it work with extendinfo script but I doubt that all shows on calendar will have it info on the site it take info from

extra

I can make similar window with description being longer and cast cut of - but I would need to know what info we can get 👍

bigretromike commented 5 years ago

The best would be info if given series is in your collection, if so all info about it (latest watched episode, how many local episode you got) so you check check with calendar how far behind you are :-), how many episode there is for given series

da3dsoul commented 5 years ago

It can try. If it's a season 2 or something, it can fall back on cast for that

bigretromike commented 5 years ago

In ideal work calendar series should be stored so when you get episode for it you update info about series, while having big flexibility with showing new releases/calendar - also its not like each episode you create series just link to it. If you want calendar to work with extendedinfo we need 3rd party ids (like id's from other sites, that info is available on anidb but only for series entries not in calendar if I recall)

da3dsoul commented 5 years ago

No we have that. No worries 😊

bigretromike commented 5 years ago

If so Im making that window then

bigretromike commented 5 years ago

Base: extrainfo-view

Ours: naka-extrainfo-view