search

bigretromike / nakamori

Nakamori is Kodi addon that use Shoko (known as Japanese Media Manager (JMM)) Server as back-end for metadata information.
https://shokunin.monogatari.pl/nakamori/
49 stars 5 forks source link

Watch marks dissapears from Series when navigating Filter #334

Closed bigretromike closed 5 years ago

bigretromike commented 5 years ago

Step-by-step:

To refresh you need to '..' from Filter and enter it again.

da3dsoul commented 5 years ago

That sounds like a Kodi big, since that is cached by Kodi when you back into a filter

bigretromike commented 5 years ago

Please no... in this rate I will move to mpv...

da3dsoul commented 5 years ago

I know how to fix it, but it'll increase your load time in All

bigretromike commented 5 years ago

is this fix or workaround ? because I almost made issue 👍

bigretromike commented 5 years ago

It's not only in 'All' also seasons and its only affect 'Watched flag'

da3dsoul commented 5 years ago

Workaround. You disable directory caching

bigretromike commented 5 years ago

I did? So its strange it affects only 1 type of flag. Pushing ?

or you meant: My workaround is disabling directory caching ?:P because if so, then don't do it.

da3dsoul commented 5 years ago

The workaround is to disable caching. It hasn't been done yet. That was prolly a language barrier issue.

bigretromike commented 5 years ago

more like a mental shortcut issue.

bigretromike commented 5 years ago

This does not affect Search yet, disabling cache don't resolve issue in ALL - it looks more and more that's not Kodi fault.

bigretromike commented 5 years ago

My bad, disabling does resolve it - so it is a Kodi bug after all.

bigretromike commented 5 years ago

@da3dsoul looks like it could be our issue I wanted to create the smallest possible example of the issue. I used my previouse code from pull request, and while using cachetodisk the issue is not present. plugin.video.14573.zip

bigretromike commented 5 years ago

Updated version I set watch icon as we do currently. It could be something with your ListItem custom object. not sure. I don't have time to snip your code to check whats wrong - also Im unable post this with my current xbmc issue because this prove that nothing wrong there.

plugin.video.14573_2.zip

da3dsoul commented 5 years ago

I can verify that it doesn't happen on Kodi 17, with or without cache, so regardless, it is Kodi's fault. Kodi is supposed to take extended classes so that you can extend functionality and subscribe to ListItem back end stuff. If that's what causes the issue, then okay, but still not our fault, per say.

da3dsoul commented 5 years ago

I'm starting a new job in a few hours, so I've no time to help with this for at least a day.

bigretromike commented 5 years ago

Thanks for the info.

I'm hopping when you have time you can make example that show the issue, because I don't want to do offline nakamori version just to show this bug.

da3dsoul commented 5 years ago

IKR

bigretromike commented 5 years ago

Have a good day at new work

da3dsoul commented 5 years ago

You should update the Kodi issue with what we've seen and say we'll keep looking at it and keep them posted.

bigretromike commented 5 years ago

While I was writing the update for issue I added your custom ListItem, still no issue. Trying to add DirectoryListing() but now its fails without error ;-)

bigretromike commented 5 years ago

Version with copy of DirectoryListing() but not using it because it don't show anything. Just in case... plugin.video.14573_v3.zip

bigretromike commented 5 years ago

I was hoping that this would be fixed. I'm starting to doubt in that and that its and Kodi issue because I enabled cache all over others Objects and I never was able to reproduce this issue anywhere but Filter

Until you find the time to fix it, or user being impact by slower loading times of Filters I'm disabling cache for Filters.