search

bigretromike / nakamori

Nakamori is Kodi addon that use Shoko (known as Japanese Media Manager (JMM)) Server as back-end for metadata information.
https://shokunin.monogatari.pl/nakamori/
49 stars 5 forks source link

Kodi 19 #381

Closed ElementalCrisis closed 3 years ago

ElementalCrisis commented 3 years ago

Hey BRM, were getting asked about a Kodi 19 compatible version of Nakamori and was wondering if its in the works or if Nakamori will only work on Kodi 18 and below?

bigretromike commented 3 years ago

yes. I just patched quick and dirty version for Kodi19.

I will try to have it up and running in few hours.

After that I will be redoing it so everything will work as it used to.

bigretromike commented 3 years ago

@ElementalCrisis https://github.com/bigretromike/nakamori/releases/tag/3.6.0

ElementalCrisis commented 3 years ago

Oh awesome, I'll give it a go later today!

bigretromike commented 3 years ago

@ElementalCrisis It will work with pre 4.0-shokoserver - that was what I have installed. But I need some time to make it work with newest version. Lots of things changes sice 3.9.x :-) but project is not dead

ElementalCrisis commented 3 years ago

No worries, let me know once its works with the latest version of Shoko and I'll make a blog post about it. :)

kusco123 commented 3 years ago

Hello bigretromike - still working on this or to be considered dead?

bigretromike commented 3 years ago

@kusco123 hello, yeah stilling working. probably because I'm putting more time into work. I'm thinking about it once a week.

Looks like I need to upgrade shoko server so I will finally have broken installation and bigger need to fix this.

In 2 weeks I will have paid vacations from work, so that will be a probably good idea to start digging into code.

Edit: Thanks for asking

kusco123 commented 3 years ago

Cool - happy to see that it is still breathing :)

@kusco123 hello, yeah stilling working. probably because I'm putting more time into work. I'm thinking about it once a week.

Looks like I need to upgrade shoko server so I will finally have broken installation and bigger need to fix this.

In 2 weeks I will have paid vacations from work, so that will be a probably good idea to start digging into code.

Edit: Thanks for asking

Cool - happy to see that it is still breathing :)

ElementalCrisis commented 3 years ago

Hey @bigretromike

Congrats on the release! I'll write something up for the site to spread the news.

Besides support for Kodi 19, is there anything else you'd like me to mention?

Also is there a changelog?

bigretromike commented 3 years ago

@ElementalCrisis Hello. Thanks ! Besides building it from scratch for Kodi 19, it also is fully compatible with ShokoServer 4.1.x. Nothing to fancy - for now there is no change log, but surely there will be one, when I'm done with calendar.

bigretromike commented 3 years ago

Also I will be updating stable repository, as for now only dev one is up2date, so you can wait 2more days until I get around it and make it right @ElementalCrisis I didn't haste to inform you because I wanted to finish the 'old' stable repository so everyone that had been using it would get update - but I did not figure out how not to nuke them so I will probably make one new repository as for now we not using multiply modules just for one plugin :-)

ElementalCrisis commented 3 years ago

Sounds good!

Send me a message on Discord when it's all ready to go! :)

ElementalCrisis commented 2 years ago

Hey BRM, just checking in and seeing how it's coming along.

bigretromike commented 2 years ago

@ElementalCrisis fell free to link stable repository - im currently testing 19.3 but for anything less (matrix) this repo will do: shokunin.monogatari.pl/repo/repository.nakamori.zip

ElementalCrisis commented 2 years ago

Sorry for the late response, I don't get notified apparently of replies and have been busy.

I'll make the blog post this week. Anything in particular you'd like me to mention in it?

bigretromike commented 2 years ago

@ElementalCrisis postpone that news, I would like to review code against newest shoko+kodi. No need to "announce" something that is not tested with latest v.

ElementalCrisis commented 2 years ago

No problem, I've been busy so haven't had a chance to type it out yet.

Let me know when you're ready.