bigretromike / nakamori

Nakamori is Kodi addon that use Shoko (known as Japanese Media Manager (JMM)) Server as back-end for metadata information.
https://shokunin.monogatari.pl/nakamori/
49 stars 5 forks source link

Main Title instead of Official Title Setting only applies at Series Level instead of group level #76

Closed da3dsoul closed 8 years ago

da3dsoul commented 8 years ago

When you have series grouped by relevance, it only converts the series name, not the group name. Even if this were fixed, it would only work if the name was the same as one of the underlying shows, otherwise there would be nowhere to pull a different name from. I noticed in the screenies I posted to the other one. Ghostory was used instead of Bakemonogatari.

bigretromike commented 8 years ago

You did alot of testing there :+1: Thanks I have a lot to work on now ;-)

da3dsoul commented 8 years ago

This one still applies on Confluence

bigretromike commented 8 years ago

Could I ask you how did you change grouping by relevance?

da3dsoul commented 8 years ago

In JMM Desktop, in the settings tab, under essential? (I'm at work, I think it's essential), toward the bottom there is a check box and a button that says "Recreate all groups"

bigretromike commented 8 years ago

I see it :-) will test it out because I never used this before ;-)

da3dsoul commented 8 years ago

Unfortunately, there are a few issues with it, which I already reported, like not including things, depending on what order it scans. It still mostly works for things with only one or two seasons

bigretromike commented 8 years ago

Recreating took 36minuts :-) time for testing

bigretromike commented 8 years ago

This function one broke JMM for me :+1: with Nakamori hehe. I think it time to debug this on dev version :+1: because fixing old version wont be good thing

da3dsoul commented 8 years ago

Right, it will lock up the entire GUI for awhile and pretend to not be working. I have like 350 shows and it takes about 10 minutes.

da3dsoul commented 8 years ago

I also have a decent processor... That helps

da3dsoul commented 8 years ago

Well, when it finally starts getting worked on. The group name should use the first season name. JMM has the issue of naming them wrong often, but if we are overriding it, might as well fix that.

bigretromike commented 8 years ago

Nakamori don't overwrite names of series/groups. It parse the one that JMM have in database, parse them and then pick the one you prefer or the available one if your preference aren't available.

If you think JMM does something wrong I would like to ask you to make issue on JMMServer repo - so we could improve JMM while having profit in more than one project thanks to that :-)

Also option you refer does infact work for Groups, the easiest way to check it is to change lang 'en' in settings to 'ja'

Because I see the root of this problem is related to how JMM parse group names

da3dsoul commented 8 years ago

I see

da3dsoul commented 8 years ago

I forgot about this. I'll fix it in JMM

bigretromike commented 8 years ago

If you intend doing JMM fix please refer it here when done

da3dsoul commented 8 years ago

Kk

da3dsoul commented 8 years ago

I think this is fixed now

da3dsoul commented 8 years ago

This is hacked on the nakamori side, but it chooses the language setting over the one overriden in jmm. This bothers me. I have some Shows that I know by English name (every studio ghibli film) and some by x-jat name.

bigretromike commented 8 years ago

if jmm support multiply titles like I did on series, then it shouldn't be a problem. It could be also dont by adding 2 languages of your chose and add item twice with both names, but with a small collection like 1000 it would be 2000 and twice the time to load , so that would be a poor thing. Other would be to add second title on the context menu or somewhere else - or even go further and make a custom skin with additional place for information so it would show both/more titles. It all depend of how needed is this and if someone (like you) is willing to do that. It would be fun to have a 'official' nakamori skin, but we all know that some people prefer they own skins. Or just make the Kodi default one our default with additional fields

da3dsoul commented 8 years ago

The issue is that it will automatically go to the original title tag for folders/groups, bypassing any custom name.

bigretromike commented 8 years ago

In current implantation yes, why why not change jmm function ;-)

da3dsoul commented 8 years ago

I'll make a lang tag for custom/overridden titles, and then make Nakamori take that title over other preferences, with an option for strict language preference

bigretromike commented 8 years ago

that is also an option :+1:

da3dsoul commented 8 years ago

Hopefully this will be fixed soon

da3dsoul commented 8 years ago

Fixed again