search

bigretromike / nakamori

Nakamori is Kodi addon that use Shoko (known as Japanese Media Manager (JMM)) Server as back-end for metadata information.
https://shokunin.monogatari.pl/nakamori/
49 stars 5 forks source link

Unwatched episodes subtext on TV shows uses AniDB total #77

Closed da3dsoul closed 8 years ago

da3dsoul commented 8 years ago

It uses the total number of episodes that AniDB provides instead of the total number you have, including specials. It causes things to say they are unfinished even though you have watched all of the episodes but not the specials, no credit opening, etc

This occurs in JMM 3.4.6.4 and Kodi 16.0.

da3dsoul commented 8 years ago

For example, soul eater has like 26 specials...

bigretromike commented 8 years ago

Nakamori do use AniDB info for anything, it use JMM info. And JMM use AniDB info so it can bit tricky to fix this, because specials for series are inside series 'folder' and if Nakamori check this as watched without specials you could probably miss those specials even not knowing about them.

Im not sure if this would be intended - The only solution would be to introduce this to JMM to make option to make them seperate as groups

da3dsoul commented 8 years ago

I'm going to make a log spam for myself, I'll post any useful info I find out regarding anything.

bigretromike commented 8 years ago

sure and I will either way try to see what can I do from Nakamori ends ;-)

da3dsoul commented 8 years ago

Meh, I'm officially going to make a pr to jmm to add the things we'll need for convenience. Number of Specials is one thing, number of missing episodes wouldn't be a bad idea (especially since the current state will say a series is unfinished if you are missing episodes). Can you think of anything else?

da3dsoul commented 8 years ago

Kodi 16.1 stable literally just came out

bigretromike commented 8 years ago

yeah, downloading it and testing :-)

bigretromike commented 8 years ago

JMM is the one that tell how many episode is in series. And it doesnt tell how many you have localy. I added this because this could be better solution and workaround for those specials/drama you mention before. We will see if anyone else will need this as much :+1:

da3dsoul commented 8 years ago

Yeah, I've started on the JMM work, but it's really big, and I'm still familiarizing myself with the code

bigretromike commented 8 years ago

Yes it is really big and sometimes there are more hacks than solution :+1: also maybe one they some developers will move it to mono c# to make it crosscompatible