search

bigship / barcode.flutter

barcode generate library for Flutter
BSD 2-Clause "Simplified" License
59 stars 27 forks source link

Add ITF Support #19

Closed v0l closed 5 years ago

v0l commented 5 years ago

This also includes formatting and padding fixes.

I've replaced the usage of BarCodeType with an abstract class BarCodeParams which will allow custom params for each barcode type, which i believe is a change worth implementing for future expand-ability.

v0l commented 5 years ago

@bigship any thoughts/comments?

bigship commented 5 years ago

I have midterm exams this two weeks. Your solution seems good to me , I will merge it to master

Thanks !

Kieran notifications@github.com于2019年10月24日 周四03:26写道：

@bigship https://github.com/bigship any thoughts/comments?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bigship/barcode.flutter/pull/19?email_source=notifications&email_token=AAJAHVPXNQU6RXENHMFW5ADQQFE3XA5CNFSM4I7O5MSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECEAFGI#issuecomment-545784473, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJAHVMGMKTX3UQTEH4NZRLQQFE3XANCNFSM4I7O5MSA .

bigship commented 5 years ago

Sure, and adjust the README accordingly.

Kieran notifications@github.com于2019年10月24日 周四15:25写道：

I think i can add a backward compatible api too, dont commit this yet.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bigship/barcode.flutter/pull/19?email_source=notifications&email_token=AAJAHVKYC636EBPYMI4SGJLQQHZDFA5CNFSM4I7O5MSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECGE73I#issuecomment-546066413, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJAHVOUABPS5BPBMVHSHBTQQHZDFANCNFSM4I7O5MSA .

v0l commented 5 years ago

I went with changing the version to 1.1.0 instead of 2.0.0 since its backward compatible, later this can be removed completely..