Closed DanDanielD closed 2 months ago
Depends on: https://github.com/bigshortbets/indexer/pull/75
@autopilot
@autopilot
Hi @Klapeyron,
Thank you for the update. I have noted the dependency on https://github.com/bigshortbets/indexer/issues/69. Once that issue is resolved, we can proceed with the renaming changes as described.
If you need any further assistance or have additional questions, feel free to ask!
Best regards, Autopilot
@autopilot
@autopilot
Hi @Klapeyron,
Is there anything specific you need assistance with regarding this issue? Please let me know how I can help!
Best regards, Autopilot
@autopilot solve this issue
@autopilot solve this issue
Hi @Klapeyron,
To solve this issue, please follow these steps:
Update the Labels in the Codebase:
Ensure the Calculations for Used Balance are Correct:
Update the UI:
Test the Changes:
Update Documentation:
Resolve Dependencies:
If you need any specific code snippets or further assistance with any of these steps, please let me know!
Best regards, Autopilot
@autopilot propose code solution
@autopilot propose code solution
Hi @Klapeyron,
Sure, here is a proposed code solution to address the renaming and calculation changes:
const labels = {
totalDeposits: "Total Deposits",
marketDeposit: "Market Deposit",
};
const labels = {
usedBalance: "Used Balance",
marketMargin: "Market Margin",
};
const totalDeposits = initialMarginsOpenOrders + initialMarginsOpenPositions + marketDeposits;
const usedBalance = initialMarginsOpenOrders + initialMarginsOpenPositions + marketMargins;
<div>
<label>{labels.totalDeposits}</label>
<span>{totalDeposits}</span>
</div>
<div>
<label>{labels.marketDeposit}</label>
<span>{marketDeposits}</span>
</div>
<div>
<label>{labels.usedBalance}</label>
<span>{usedBalance}</span>
</div>
<div>
<label>{labels.marketMargin}</label>
<span>{marketMargins}</span>
</div>
Ensure that the UI reflects the new labels and calculations correctly. You can use unit tests or manual testing to verify the changes.
Update any relevant documentation to reflect the new terminology. For example, if you have a README or a user guide, make sure to update the terms "Total Deposits" and "Market Deposit" to "Used Balance" and "Market Margin" respectively.
Ensure that the dependency on https://github.com/bigshortbets/indexer/issues/69 is resolved before proceeding with these changes.
If you need further assistance or specific code snippets for a particular framework or library, please let me know!
Best regards, Autopilot
@autopilot dependency is resolved
@autopilot dependency is resolved
Hi @Klapeyron,
Great to hear that the dependency is resolved! Here are the steps to implement the changes:
const labels = {
totalDeposits: "Total Deposits",
marketDeposit: "Market Deposit",
};
const labels = {
usedBalance: "Used Balance",
marketMargin: "Market Margin",
};
const totalDeposits = initialMarginsOpenOrders + initialMarginsOpenPositions + marketDeposits;
const usedBalance = initialMarginsOpenOrders + initialMarginsOpenPositions + marketMargins;
<div>
<label>{labels.totalDeposits}</label>
<span>{totalDeposits}</span>
</div>
<div>
<label>{labels.marketDeposit}</label>
<span>{marketDeposits}</span>
</div>
<div>
<label>{labels.usedBalance}</label>
<span>{usedBalance}</span>
</div>
<div>
<label>{labels.marketMargin}</label>
<span>{marketMargins}</span>
</div>
Ensure that the UI reflects the new labels and calculations correctly. You can use unit tests or manual testing to verify the changes.
Update any relevant documentation to reflect the new terminology. For example, if you have a README or a user guide, make sure to update the terms "Total Deposits" and "Market Deposit" to "Used Balance" and "Market Margin" respectively.
If you need further assistance or specific code snippets for a particular framework or library, please let me know!
Best regards, Autopilot
Associated with: https://github.com/bigshortbets/market-frontend/issues/93
We have revised the design and will now display three elements: Account Balance, Available Balance, and Market Margin (which will remain unchanged).
Account Balance will represent the sum of:
Available Balance will represent the user's accessible funds.
Following the agreed logic for displaying fund structure on the market, the following changes are required:
-Rename "Total Deposits" to "Used Balance". -Rename "Market Deposit" to "Market Margin".
As per the planned design, Used Balance will display the sum of the following amounts: -All initial margins currently reserved for open orders -All initial margins of open positions -All market margins Market Deposit will be renamed to Market Margin for better clarity.
Screenshot of the expected result: