search

bigskysoftware / htmx-extensions

103 stars 30 forks source link

htmx-2 regression: WebSocket extension no longer sends hx-vals along with calls #10

Closed aral closed 2 weeks ago

aral commented 4 months ago

In htmx-1, WebSocket calls sent the data in hx-vals attributes on elements that had ws-send defined on them (see passing test: https://github.com/bigskysoftware/htmx/pull/2416)

In htmx-2, WebSocket calls do not send hx-vals (see failing test: https://github.com/bigskysoftware/htmx-extensions/compare/main...aral:htmx-extensions:ws-hx-vals-test).

aral commented 3 months ago

Can we close this issue now that this has been implement in https://github.com/bigskysoftware/htmx/pull/2418?

1cg commented 2 weeks ago

thank you!