search

bigskysoftware / htmx-extensions

103 stars 30 forks source link

hx-ext="sse" elements should include hx-vals attributes as query params #34

Open bradleyjkemp opened 4 weeks ago

bradleyjkemp commented 4 weeks ago

I want to be able send some dynamic query params as part of an sse request like so:

<div hx-ext="sse" sse-connect="/events" hx-vals="js:{dynamicValue: foo()}>

But the hx-vals are not included in the eventsource connect: https://github.com/bigskysoftware/htmx-extensions/blob/ba3d1675bc5a89c870df8ec5a1ac126e408467b8/src/sse/sse.js#L178-L185 https://github.com/bigskysoftware/htmx-extensions/blob/ba3d1675bc5a89c870df8ec5a1ac126e408467b8/src/sse/sse.js#L191-L192

Only the value of sse-connect is used