Without uBlock, the button's alt-text would be 1px lower than the rest
of the nav items, and inconsistently capitalized.
With uBlock, the button would be slightly too high up. Screenshot of problem:
The solution is to apply styles on the span that GitHub's JS inserts.
However, using margin will make the entire nav jump during pageload, so
position: relative seems more robust there.
Testing
Tested in Firefox and Chrome latest
Checklist
[x] I have read the contribution guidelines
[x] I have targeted this PR against the correct branch (master for website changes, dev for
source changes)
[x] This is either a bugfix, a documentation update, or a new feature that has been explicitly
approved via an issue
[x] I ran the test suite locally (npm run test) and verified that it succeeded
Description
Without uBlock, the button's alt-text would be 1px lower than the rest of the nav items, and inconsistently capitalized.
With uBlock, the button would be slightly too high up. Screenshot of problem:
The solution is to apply styles on the
spanthat GitHub's JS inserts. However, using margin will make the entire nav jump during pageload, so position: relative seems more robust there.Testing
Tested in Firefox and Chrome latest
Checklist
masterfor website changes,devfor source changes)npm run test) and verified that it succeeded