search

bigskysoftware / idiomorph

A DOM-merging algorithm
BSD 2-Clause "Simplified" License
641 stars 32 forks source link

Simplify logic at places #4

Closed piranha closed 1 year ago

piranha commented 1 year ago

There are two commits: one about flattening morphChildren needs repeated removeIdsFromConsideration (btw, I don't cache ids and it seems to perform ok, so maybe you want to experiment with this?), and another about syncNodeFrom seems like a no-brainer with a little helper.

hastebrot commented 7 months ago

I think, this change introduced a bug when morphing an <input> and updating the checked attribute and property.

idiomorph@0.0.8 does not have this bug, idiomorph@0.0.9 has the bug. I need to further investigate and find the exact commit. will provide an example when I have time.

update: bug was introduced in "simplify syncNodeFrom a bit" (https://github.com/bigskysoftware/idiomorph/pull/4/commits/3682987eb154e1c41080d1fcb49bdd77881889ae)